Repository navigation
Fix segfault on empty input for neumaier and c sum types - #5
Open
billdenney wants to merge 2 commits into
Open
billdenney wants to merge 2 commits into
billdenney wants to merge 2 commits into
Conversation
PreciseSums_NeumaierSum and PreciseSums_DoubleSum read input[0] before the loop with no length guard, so psSum(numeric(0)) with sum type 'neumaier' or 'c' performed an out-of-bounds read and crashed R. valgrind: Invalid read of size 8 at PreciseSums_NeumaierSum (sum.c:124) called from _psSum (sum.c:373). The other sum types already return 0 for empty input; make these two consistent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…gfault) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreciseSums_NeumaierSum and PreciseSums_DoubleSum read input[0] before their for(i=1;i<len;…) loop with no length guard, so psSum(numeric(0)) with sum type "neumaier" or "c" performs an out-of-bounds read and crashes R.
Reproducer: psSetSum("neumaier"); psSum(numeric(0)) → "An irrecoverable exception occurred".
Validation: valgrind → Invalid read of size 8 at PreciseSums_NeumaierSum (sum.c:124) ← _psSum (sum.c:373).
The other four algorithms already return 0 for empty input; this makes the two consistent. Verified: all six types now return 0 for empty input, unchanged for non-empty.