Skip to content

List only the candidate frames that reached the disk #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmbrthirteen merged 2 commits into from
Sep 6, 2026
Merged

List only the candidate frames that reached the disk #216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abfa202
Compare thumbnail candidates by identity, not by their frames
nmbrthirteen Sep 6, 2026
c55370c
List only the candidate frames that reached the disk
nmbrthirteen Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions backend/services/thumbnail_ai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,9 @@ def _too_similar(a: dict, b: dict) -> bool:
for c in candidates:
if len(selected) >= count:
break
if c in selected:
# Identity, not equality: these dicts hold a numpy frame, and
# comparing two of them raises rather than answering.
if any(c is s for s in selected):
continue
if any(_too_similar(c, s) for s in selected):
continue
Expand Down Expand Up @@ -449,7 +451,13 @@ def _too_similar(a: dict, b: dict) -> bool:
fh, fw = frame.shape[:2]
if (fw, fh) != (target_w, target_h):
frame = cv2.resize(frame, (target_w, target_h), interpolation=cv2.INTER_LANCZOS4)
cv2.imwrite(path, frame, [cv2.IMWRITE_JPEG_QUALITY, 92])
# imwrite answers a failed write with False rather than raising, and a
# full disk is the usual reason. Listing the path regardless hands the
# renderer a frame that is not on disk, which it refuses.
if not cv2.imwrite(path, frame, [cv2.IMWRITE_JPEG_QUALITY, 92]):
log_event("thumbnail-ai", "could not write candidate frame",
level="warn", path=path)
continue
results.append({
"path": path,
"timestamp": c["timestamp"],
Expand Down