Skip to content

feat(emoji-picker): add bar widget that opens the compact picker panel - #879

Merged
ItsLemmy merged 2 commits into
noctalia-dev:mainfrom
ZhangDM-520:feat/emoji-picker-widget
Oct 2, 2026
Merged

ItsLemmy merged 2 commits into
noctalia-dev:mainfrom
ZhangDM-520:feat/emoji-picker-widget

Conversation

@ZhangDM-520

@ZhangDM-520 ZhangDM-520 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Plugin

  • Id: liamwh/emoji-picker

  • New plugin

  • Update to an existing plugin (version bumped in plugin.toml)

What it does

Adds a minimal bar-widget entry (widget, glyph mood-smile) so the plugin appears in the shell's add-widget picker — the picker only lists plugin [[widget]] entries, so this panel-only plugin never showed up there. Clicking the widget toggles the compact picker panel via noctalia.togglePanel("liamwh/emoji-picker:compact"), the same registry path the panel IPC uses. Version 1.0.1 → 1.1.0. README.md documents the new entry. The three panel entries (wide, desktop, compact) are unchanged; this PR only adds the bar entry.

External dependencies

None

Testing

Live-tested end to end on Niri + Noctalia 5.2.0 with the plugin enabled from a local source at 1.1.0: the widget is listed in the add-widget picker ("Emoji & Symbol Picker") and can be placed on the bar; clicking it opens the compact panel (panel target verified through the same IPC path the widget's onClick uses).

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Noctalia version tested against: 5.2.0
  • Plugin API level: 28

Screenshots / Videos

Emoji-picker widget (this PR):

Emoji-picker widget

Processes widget (sibling change, for context):

Processes widget

Checklist

Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the
    README template, documents
    every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • thumbnail.webp is present and relevant; for a new plugin I created it with the thumbnail generator, and for an update I regenerated it with the generator if the visual identity or user-facing appearance changed.
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
    understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

The bar-widget picker only lists plugin [[widget]] entries, so the
panel-only plugin never appeared there. Add a minimal widget entry
(glyph mood-smile) whose click toggles the compact panel via
noctalia.togglePanel. Version 1.0.1 -> 1.1.0.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Noctalia-CI
Noctalia-CI marked this pull request as draft September 30, 2026 10:33
@Noctalia-CI

Noctalia-CI commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

The description now contains the required template structure.

@Noctalia-CI

Copy link
Copy Markdown
Contributor

CC @liamwh: this pull request was automatically moved to draft until you have had a chance to look at it. It will be marked ready for review automatically once you reply here.

@ItsLemmy

Copy link
Copy Markdown
Contributor

Waiting on @liamwh, keep it draft until they reply.

@ItsLemmy
ItsLemmy marked this pull request as draft September 30, 2026 22:08
@liamwh

liamwh commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Finally got around to this. Nice little entry, and thanks for keeping it to eight lines.

One change before I sign off. Please add "bar" to tags in plugin.toml. Tags drive catalogue search, and every plugin that ships a bar widget tags it, so as it stands this won't appear for anyone filtering by surface. Best to fold it into this PR since 1.1.0 is already bumping; a tag-only follow-up would need its own version bump.

The rest looks right to me: manifest fields, the togglePanel path, the README update. Happy to approve once the tag lands.

@Noctalia-CI
Noctalia-CI marked this pull request as ready for review October 1, 2026 13:23
@ZhangDM-520

Copy link
Copy Markdown
Contributor Author

One change before I sign off. Please add "bar" to tags in plugin.toml. Tags drive catalogue search, and every plugin that ships a bar widget tags it, so as it stands this won't appear for anyone filtering by surface. Best to fold it into this PR since 1.1.0 is already bumping; a tag-only follow-up would need its own version bump.

understood, thanks for your engagement ❤️. it's night now in my region; I will make it tomorrow ASAP

@ItsLemmy
ItsLemmy marked this pull request as draft October 1, 2026 22:19
The bar widget ships in 1.1.0, and every plugin that ships a bar widget
tags it — without it the plugin is missing from catalogue searches
filtered by surface. Folded into the 1.1.0 bump per review.
@ZhangDM-520

Copy link
Copy Markdown
Contributor Author

Done — "bar" is now in tags in plugin.toml (a47cc08), folded into the 1.1.0 bump as suggested. Ready for another look.

@ZhangDM-520
ZhangDM-520 marked this pull request as ready for review October 1, 2026 23:38
@ItsLemmy

ItsLemmy commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

keep it draft until @liamwh reply, thx.

@ItsLemmy
ItsLemmy marked this pull request as draft October 2, 2026 00:03
@liamwh

liamwh commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Looks great, thanks! 👍

@Noctalia-CI
Noctalia-CI marked this pull request as ready for review October 2, 2026 09:58
@ItsLemmy
ItsLemmy merged commit c8a84c3 into noctalia-dev:main Oct 2, 2026
3 checks passed
@ZhangDM-520
ZhangDM-520 deleted the feat/emoji-picker-widget branch October 2, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants