fix: use on_primary theme color for sync and bump plugin_api for noct… - #902
ChristPetitjean wants to merge 1 commit into
Conversation
…alia.getColor support
|
This pull request was converted to a draft because its description is missing required Missing:
Add the items above to the description, keeping their exact wording, then mark the pull Sections that only offer context may be deleted; nothing else about this pull request was |
|
CC @detluck: this pull request was automatically moved to draft until you have had a chance to look at it. It will be marked ready for review automatically once you reply here. |
|
I actually wanted to use I think we can simplify the implementation by using the native Noctalia API instead of adding Pywal/Wallust fallbacks. Since It could also lead to the Razer lighting using a color that doesn't match the current Noctalia theme if the cached Pywal colors are from a different wallpaper/theme. The built-in palette fallback should also be unnecessary for the same reason I'd suggest keeping it simple: use P.S. I also think a selector for which theme color to sync would be a really nice addition. For example, letting the user choose between |
|
This pull request was converted to a draft because its description is missing required Missing:
Add the items above to the description, keeping their exact wording, then mark the pull Sections that only offer context may be deleted; nothing else about this pull request was |
…alia.getColor support
Plugin
<author>/<plugin>plugin.toml)What it does
Use noctalia.getColor("on_primary") to support dynamic wallpaper color extraction and better contrast.
Added Pywal/Wallust fallback for CachyOS users.
External dependencies
Testing
Screenshots / Videos
Checklist
Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpis present and relevant; for a new plugin I created it with the thumbnail generator, and for an update I regenerated it with the generator if the visual identity or user-facing appearance changed.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.
licensedeclared inplugin.toml.