Skip to content

[v20.x] Revert "deps: update undici to 6.13.0" - #53520

Closed
marco-ippolito wants to merge 3 commits into
nodejs:v20.x-stagingfrom
marco-ippolito:feat/revert-undici
Closed

[v20.x] Revert "deps: update undici to 6.13.0"#53520
marco-ippolito wants to merge 3 commits into
nodejs:v20.x-stagingfrom
marco-ippolito:feat/revert-undici

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented Jun 20, 2024

Copy link
Copy Markdown
Member

Refs: #53186
Refs: nodejs/undici#3267
Refs: #53486
Reverts undici to v6.6.2
cc @mcollina

@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/undici

@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. v20.x labels Jun 20, 2024
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2024

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a no go. This has the following vulns:

GHSA-m4v8-wqvr-p9f7
GHSA-9qxr-qj54-h672
GHSA-3787-6prv-h9w3

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants