Skip to content

doc: remove outdated TLS authorized docs warning #65597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pimterry wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −9
Open

doc: remove outdated TLS authorized docs warning #65597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions doc/api/tls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,6 +1094,11 @@

<!-- YAML
added: v0.11.4
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/64677

Check warning on line 1099 in doc/api/tls.md

View workflow job for this annotation

GitHub Actions / lint-pr-url 

pr-url doesn't match the URL of the current PR.
description: On TLS 1.3, a resumed session where the client presented no
certificate is no longer reported as authorized.
-->

* Type: {boolean}
Expand All @@ -1103,15 +1108,10 @@

The peer certificate is only verified during a full TLS handshake. When a
connection is established by resuming a previous session (see
[Session Resumption][]), verification is not repeated. If the client
presented a certificate in the original handshake, `authorized` and
[Session Resumption][]), verification is not repeated: `authorized` and
`authorizationError` carry the result stored with the session, including
any verification error. On TLS 1.3, a client that sent no certificate at
all can resume a session and report `authorized` as `true`, while
[`tls.TLSSocket.getPeerCertificate()`][] returns an empty object. Servers
that authorize clients manually with `rejectUnauthorized: false` should
therefore also check [`tls.TLSSocket.isSessionReused()`][] and that a peer
certificate is present.
any verification error and the case where the client presented no
certificate at all.

### `tlsSocket.disableRenegotiation()`

Expand Down Expand Up @@ -2625,7 +2625,6 @@
[`tls.TLSSocket.getProtocol()`]: #tlssocketgetprotocol
[`tls.TLSSocket.getSession()`]: #tlssocketgetsession
[`tls.TLSSocket.getTLSTicket()`]: #tlssocketgettlsticket
[`tls.TLSSocket.isSessionReused()`]: #tlssocketissessionreused
[`tls.TLSSocket.servername`]: #tlssocketservername
[`tls.TLSSocket`]: #class-tlstlssocket
[`tls.connect()`]: #tlsconnectoptions-callback
Expand Down
Loading