tools: offset GitHub crons by 3 minutes - #65612
Conversation
|
Review requested:
|
It might increase the chance of them being scheduled. Refs: nodejs/build#4443 Refs: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#schedule Signed-Off-By: Michaël Zasso <targos@protonmail.com>
sxa
left a comment
There was a problem hiding this comment.
Looks like you've removed the quote marks around this - was that intentional?
But no objection otherwise from me - whether it would prevent it being scheduled for hours I'm a bit sceptical about but I don't see any negatives on it so worth a try.
|
I removed the quote marks because the linter complained abouth them: https://github.com/nodejs/node/actions/runs/33155298528/job/98796532067 I'm sceptical too, but I don't know what else to do. This PR is based on this sentence from the GitHub documentation:
|
That seems a bit odd given that the examples in the docs have quotes (albeit single) in them.
yeah that's reasonable ... As I say there shouldn't be any negatives from this. I've just triggered a manual PR test on #62251 because it hadn't triggered from the |
sxa
left a comment
There was a problem hiding this comment.
If my experience of it not triggering at all is the same for other people's PRs then we might as well put this in and see if anything objects to the absent quotes. I'm just a little nervous about the (hopefully small) risk of it not triggering because of that.
Although we've had a few triggers overnight so we should notice if we get none!
|
Fast-track has been requested by @panva. Please 👍 to approve. |
|
The quotes are optional. YAML parses the unquoted value as a string. I don't believe this is going to do anything but it's worth a try and as @targos said it's about the only thing we can do outside of having a cron in jenkins trigger this through workflow_dispatch which comes with its own slew of considerations. |
aduh95
left a comment
There was a problem hiding this comment.
Is 3 arbitrary or based on something? In any case, it doesn't cost much to try
It might increase the chance of them being scheduled. Refs: nodejs/build#4443 Refs: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#schedule Signed-Off-By: Michaël Zasso <targos@protonmail.com> PR-URL: #65612 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Landed in 523e583 |
Arbitrarily chosen by me. |
It might increase the chance of them being scheduled.
Refs: nodejs/build#4443
Refs: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#schedule