Skip to content

tools: offset GitHub crons by 3 minutes - #65612

Closed
targos wants to merge 1 commit into
nodejs:mainfrom
targos:build-4443
Closed

tools: offset GitHub crons by 3 minutes#65612
targos wants to merge 1 commit into
nodejs:mainfrom
targos:build-4443

Conversation

@targos

@targos targos commented Aug 28, 2026

Copy link
Copy Markdown
Member

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 28, 2026
It might increase the chance of them being scheduled.

Refs: nodejs/build#4443
Refs: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#schedule
Signed-Off-By: Michaël Zasso <targos@protonmail.com>

@sxa sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've removed the quote marks around this - was that intentional?

But no objection otherwise from me - whether it would prevent it being scheduled for hours I'm a bit sceptical about but I don't see any negatives on it so worth a try.

@targos

targos commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

I removed the quote marks because the linter complained abouth them: https://github.com/nodejs/node/actions/runs/33155298528/job/98796532067

I'm sceptical too, but I don't know what else to do. This PR is based on this sentence from the GitHub documentation:

The schedule event can be delayed during periods of high loads of GitHub Actions workflow runs. High load times include the start of every hour. If the load is sufficiently high enough, some queued jobs may be dropped. To decrease the chance of delay, schedule your workflow to run at a different time of the hour.

@sxa

sxa commented Aug 28, 2026

Copy link
Copy Markdown
Member

I removed the quote marks because the linter complained about them:

That seems a bit odd given that the examples in the docs have quotes (albeit single) in them.

I'm sceptical too, but I don't know what else to do.

yeah that's reasonable ... As I say there shouldn't be any negatives from this. I've just triggered a manual PR test on #62251 because it hadn't triggered from the request-ci label after 13 hours...

@sxa sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If my experience of it not triggering at all is the same for other people's PRs then we might as well put this in and see if anything objects to the absent quotes. I'm just a little nervous about the (hopefully small) risk of it not triggering because of that.

Although we've had a few triggers overnight so we should notice if we get none!

@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Aug 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@panva

panva commented Aug 28, 2026

Copy link
Copy Markdown
Member

The quotes are optional. YAML parses the unquoted value as a string.

I don't believe this is going to do anything but it's worth a try and as @targos said it's about the only thing we can do outside of having a cron in jenkins trigger this through workflow_dispatch which comes with its own slew of considerations.

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 3 arbitrary or based on something? In any case, it doesn't cost much to try

panva pushed a commit that referenced this pull request Aug 28, 2026
It might increase the chance of them being scheduled.

Refs: nodejs/build#4443
Refs: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#schedule
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #65612
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva

panva commented Aug 28, 2026

Copy link
Copy Markdown
Member

Landed in 523e583

@panva panva closed this Aug 28, 2026
@panva panva removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 28, 2026
@targos

targos commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

Is 3 arbitrary or based on something? In any case, it doesn't cost much to try

Arbitrarily chosen by me.

@targos
targos deleted the build-4443 branch August 28, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants