Skip to content

test: deflake test-watch-mode-restart-esm-loading-error #65623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christianaurichzm wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

test: deflake test-watch-mode-restart-esm-loading-error #65623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/sequential/test-watch-mode-restart-esm-loading-error.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function runInBackground({ args = [], options = {}, completed = 'Completed runni
future.resolve();
return { stdout, stderr };
},
restart(timeout = 1000) {
restart(timeout = common.platformTimeout(10_000)) {
if (!child) {
run();
}
Expand Down Expand Up @@ -113,7 +113,7 @@ try {

// Update file with syntax error
const syntaxErrorContent = `console.log('hello, wor`;
const failedRestart = restart(common.platformTimeout(10_000));
const failedRestart = restart();
writeFileSync(file, syntaxErrorContent);
await sleep(common.platformTimeout(1000));
// Wait for the failed restart
Expand All @@ -125,7 +125,7 @@ try {
`Failed running ${inspect(file)}. Waiting for file changes before restarting...`,
]);

const successfulRestart = restart(common.platformTimeout(10_000));
const successfulRestart = restart();
writeFileSync(file, `console.log('hello again, world');`);
await sleep(common.platformTimeout(1000));
const { stderr: stderr3, stdout: stdout3 } = await successfulRestart;
Expand Down
Loading