src: fix TextDecoder large-input and error paths

[JosephDoUrden]

Fixes #47645.

TextDecoder('utf-16le').decode(new Uint16Array(2**27)) throws ERR_ENCODING_INVALID_ENCODED_DATA even though the input is valid and the result (134M chars) fits comfortably in a V8 string. Root cause analysis is in the issue thread: ConverterObject::Decode() sizes the ICU target as 2 * min_char_size * input length UChars. min_char_size() is the minimum number of bytes per character, so multiplying by it inflates the bound instead of tightening it. For UTF-16 that requests 4x the input in UChars, which crosses ucnv_toUnicode()'s target range validation (0x3fffffff UChars) at exactly 2**27 elements, and ICU rejects the call before looking at a single byte. The failure then gets reported by the blanket invalid-data throw at the bottom of the function.

Two changes, same function:

The bound becomes 2 * (input length + pending bytes) / min_char_size, clamped to the ICU cap. Each character consumes at least min_char_size bytes and emits at most a surrogate pair, and bytes carried over from a previous chunk complete a character in this one, so they count too. For every min_char_size == 1 encoding (all the CJK ones) this is the same as or larger than the old bound, so nothing tightens there. Only utf-16le/be change, from 4x to 1x. After the change the whole representable range decodes: an input of 2 * MAX_STRING_LENGTH bytes produces exactly a MAX_STRING_LENGTH string.

Second, Decode() now returns after a failed StringBytes::Encode() instead of falling through, so the exception Encode scheduled (ERR_STRING_TOO_LONG for oversized results) is no longer replaced by ERR_ENCODING_INVALID_ENCODED_DATA. Boundary behaviour measured locally: 2 * MAX_STRING_LENGTH bytes decodes, +2 bytes throws ERR_STRING_TOO_LONG, lone surrogate with fatal: true still throws ERR_ENCODING_INVALID_ENCODED_DATA.

On the interaction with #61559 / #61041: I know the direction is to move TextDecoder off ICU, and #61559 would take utf-16 out of this path entirely. But big5, euc-jp, euc-kr, gb18030, shift_jis and iso-2022-jp keep routing through ConverterObject::Decode(), and the error-path fix applies to all of them, so this stands regardless of when the fast-path work lands. Happy to rebase if #61559 moves first.

Tests are in pummel because of the working set (~1.6 GiB and ~3 GiB peaks, both under the existing test-buffer-large-size-* ceiling). The streaming case uses an odd byte split so a code unit actually stays pending across the chunk boundary, and compares content, not just length. Everything ran locally on both a small-icu and a full-icu build: the two pummel tests (including the gb18030 ERR_STRING_TOO_LONG case, which needs full-icu), parallel/test-whatwg-encoding* and parallel/test-icu-*, plus an A/B sweep against an unpatched build of the same tree (91 sizes per endianness, no behaviour change other than the fixed cases) and a mid-character gb18030 streaming split to exercise the pending-bytes term on a min_char_size == 1 encoding.

Known remaining limitation: results that could never fit in a string (more than 0x3fffffff UChars, i.e. inputs over ~2 GiB) still surface the blanket error rather than ERR_STRING_TOO_LONG. Fixing that needs a chunked conversion loop; it did not seem worth the extra risk in this change.

AI disclosure: I used an AI coding agent for parts of the investigation and drafting. I verified the root cause against the ICU and Node sources myself, and every number in this description comes from runs on my own machine.

[github-actions]

Benchmark GHA (util / text-decoder): https://github.com/nodejs/node/actions/runs/33238297431

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (7b0de5e) to head (953b4f5).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #65634   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files         754      754           
  Lines      255722   255720    -2     
  Branches    48314    48318    +4     
=======================================
+ Hits       230281   230289    +8     
- Misses      16555    16557    +2     
+ Partials     8886     8874   -12     

Files with missing lines	Coverage Δ
src/node_i18n.cc	78.43% <100.00%> (+0.15%)	⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.