Skip to content

typings: add fs_event_wrap internal binding types - #65661

Open
leah-1ee wants to merge 2 commits into
nodejs:mainfrom
leah-1ee:typings-fs-event-wrap
Open

typings: add fs_event_wrap internal binding types#65661
leah-1ee wants to merge 2 commits into
nodejs:mainfrom
leah-1ee:typings-fs-event-wrap

Conversation

@leah-1ee

Copy link
Copy Markdown
Contributor

Add typings for the fs_event_wrap internal binding.

Changes:

  • Added typings/internalBinding/fs_event_wrap.d.ts
  • Added fs_event_wrap to InternalBindingMap
  • Typed the FSEvent class: start(), close(), hasRef(), ref(),
    unref(), and the onchange callback

Copilot AI lite review requested due to automatic review settings August 30, 2026 07:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nodejs-github-bot nodejs-github-bot added the typings Issues and PRs related to internal TypeScript declarations. label Aug 30, 2026
Add a FsEventWrapBinding declaration for
internalBinding('fs_event_wrap') and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
@leah-1ee
leah-1ee force-pushed the typings-fs-event-wrap branch from a22fb8f to 3238647 Compare August 30, 2026 07:19
Comment thread typings/internalBinding/fs_event_wrap.d.ts Outdated
Signed-off-by: leah-1ee <selee3196@gmail.com>
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants