Skip to content

src: handle r2 errors in R2Middleware - #1071

Merged
flakey5 merged 2 commits into
mainfrom
flakey5/1069
Oct 28, 2026
Merged

flakey5 merged 2 commits into
mainfrom
flakey5/1069

Conversation

@flakey5

@flakey5 flakey5 commented Oct 25, 2026

Copy link
Copy Markdown
Member

Following #1067 we should be explicitly returning a 500 when we exhaust R2 retries now

Fixes #1069

Following #1067 we should be explicitly returning a 500 when we exhaust
R2 retries now

Fixes #1069

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5
flakey5 requested a review from a team as a code owner October 25, 2026 18:18
Comment thread src/middleware/r2Middleware.ts Resolved
Comment thread src/middleware/r2Middleware.ts Resolved

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, left some nits!

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5
flakey5 merged commit 84efb4d into main Oct 28, 2026
8 checks passed
@flakey5
flakey5 deleted the flakey5/1069 branch October 28, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: reached the end of middleware

2 participants