Repository navigation
fix(security): guard the admin controllers by class, not only by route name - #8
Merged
Merged
Conversation
…e name The access subscriber only checked routes named admin_page_layout* / admin_page_blocks*; importing the routes with a name_prefix served the layout admin without the check. The bundle's admin controllers are now guarded by class.
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full review 2026-10-28 (Medium, P1):
PageLayoutKitAdminAccessSubscriberenforced access only for routes namedadmin_page_layout*/admin_page_blocks*, and the controllers never call the checker. A host importing the bundle routes withname_prefix:(or renaming them) exposed the layout admin and block edit/update endpoints to anyone reaching them.Nowo\PageLayoutKitBundle\Controller\Admin\regardless of the route name; route-name prefixes still apply.Checks (local, Docker): cs-check, rector-dry, phpstan, igor OK; 213 tests, line coverage 100 %.
Proposed release: 1.8.1. GHSA candidate only for hosts using
name_prefix(Moderate).