Repository navigation
fix(security): refuse allow_unauthenticated in production - #9
Merged
Merged
Conversation
The switch opens the layout admin to anonymous users; the container refuses to compile with it in prod or in non-debug kernels outside test* environments.
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full review 2026-10-28 (cross-bundle, user decision):
security.allow_unauthenticated(dev/demo switch, opens the layout admin to anonymous users) now fails compilation in theprodenvironment and in non-debug kernels outsidetest*— same rule as ContactFormBundle 1.6.0. The demo already sets it tofalse.Tests: dev/test allowed, prod and non-debug staging refused. Checks (local, Docker): cs-check, rector-dry, phpstan OK; 217 tests, line coverage 100 %. Proposed release: 1.9.0.