Repository navigation
fix(acp): harden prompt suggestion handoff stripping, continuation check, and session-switch cancellation - #1
Open
mrtoaf wants to merge 1 commit into
Conversation
…eck, and session-switch cancellation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for pingdotgg#40420:
Changes
offerContinuationRunreturn value (packages/provider-acp/src/server/adapter.ts): AssignofferedContinuation = yield* offerContinuationRun(sessionId)instead of unconditionally settingofferedContinuation = true, so prompt suggestions aren't suppressed whenofferContinuationRunreturnsfalse.packages/provider-acp/src/server/adapter.ts): CallcancelPromptSuggestion()inresumeThread(when switching sessions or restarting after teardown) andreadThreadSnapshot(when loading a different session) before resettingsnapshot.inlineContextLengthon turn 2+ (packages/provider-acp/src/server/adapter.ts): Record each stored user message'sinlineContextLengthinSnapshotMessageState(without altering the stored message text returned byreadThreadSnapshot), so earlier handoff turns don't leak raw inline handoff prefixes into later turns' suggestion transcripts.apps/server/src/orchestration-v2/Adapters/AntigravityAdapterV2.test.ts): Extended the prompt-suggestion tests to cover multi-turninlineContextLengthstripping and cancellation onresumeThreadandreadThreadSnapshotsession switches.Verification
vp run check:changed nozamdavid/feat/antigravity-prompt-suggestionspassed (format,lint,knip,graphql,typecheckacross 14 packages, 37/37 tests in 2 files).Created with Gemini 4 Neon in T3 Code.