fix: walk PATH past Windows drive-letter entries - #183
Closed
dyk1454683243-sudo wants to merge 1 commit into
Closed
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
Naive splitting on ':' treats the colon in D:\... as a delimiter, so whichSync never sees later PATH directories. Preserve drive prefixes and keep scanning when a drive entry throws. Fixes npm#56 Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
Author
|
Withdrawing this PR while I clean up a high-volume open-PR backlog. Sorry for the noise — happy to come back later with a focused change if useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56.
whichSync/whichsplitPATHwithString#split(delimiter). When the delimiter is:(posix default, Git Bash-style PATH, or an explicitdelimiteroption), a Windows entry such asD:\Tools\Git\cmdis cut at the drive colon:Later directories are never checked as intact entries, so an executable that lives after a
D:\...entry is missed. Moving those drive entries to the end ofPATHmade earlier entries work, which matches the original report.This change:
:-delimitedPATHwithout treatingD:\,D:/, or a trailingD:as a separator.;-separated Windows PATH, split on;.path.win32soD:\dir+gitbecomesD:\dir\git.isexefailures (for example a not-readyD:drive) and continues walking later entries.Includes Windows-oriented regression tests for colon-separated drive paths,
;-separated Windows PATH passed withdelimiter: ':', a real executable after aD:\entry, and anisexethrow that must not abort the scan.