dbft: refactor transactions management - #164
Merged
Merged
Conversation
AnnaShaleva
force-pushed
the
blob-txs
branch
2 times, most recently
from
September 24, 2026 14:15
bd52db3 to
3edc889
Compare
AnnaShaleva
changed the title
AnnaShaleva
force-pushed
the
blob-txs
branch
3 times, most recently
from
September 28, 2026 14:20
dbd6fcd to
4ec9b34
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 62.34% 61.75% -0.59%
==========================================
Files 32 32
Lines 1572 1569 -3
==========================================
- Hits 980 969 -11
- Misses 591 599 +8
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AnnaShaleva
force-pushed
the
blob-txs
branch
3 times, most recently
from
September 28, 2026 14:46
3f5ae09 to
a94a0d3
Compare
AnnaShaleva
added a commit
to bane-labs/go-ethereum
that referenced
this pull request
Sep 28, 2026
Implement nspcc-dev/neo-go#4325, fetch nspcc-dev/dbft#164. Solves the problem described in #576 for non-blob transactions at the consensus level by adding the full list of serialized transactions to the PrepareRequest. For blob transactions the issue is still relevant. Missing blob sidecars will be requested in a separate callback and forwarded to dBFT once collected. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to bane-labs/go-ethereum
that referenced
this pull request
Sep 29, 2026
Implement nspcc-dev/neo-go#4325, fetch nspcc-dev/dbft#164. Solves the problem described in #576 for non-blob transactions at the consensus level by adding the full list of serialized transactions to the PrepareRequest. For blob transactions the issue is still relevant. Missing blob sidecars will be requested in a separate callback and forwarded to dBFT once collected. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This was referenced Sep 29, 2026
AnnaShaleva
marked this pull request as ready for review
October 1, 2026 11:18
AnnaShaleva
force-pushed
the
blob-txs
branch
2 times, most recently
from
October 1, 2026 11:44
f58ae94 to
0a3f208
Compare
roman-khimov
reviewed
Oct 1, 2026
roman-khimov
reviewed
Oct 1, 2026
1. Drop `GetTx` callback. PrepareRequest interface can deal with both present/missing transactions in its own `Transactions` callback withour allocating extra slice/map. 2. Drop `TransactionHashes`, convert `Transactions` to a slice. One data structure is enough to manage proposed transactions without extra allocations. 3. Convert `MissingTransactions` from slice to map to hanve an instant access to the missing transaction index in the proposal. A part of nspcc-dev/neo-go#4325. An alternative to #160. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
roman-khimov
approved these changes
Oct 1, 2026
AnnaShaleva
added a commit
to bane-labs/go-ethereum
that referenced
this pull request
Oct 2, 2026
Implement nspcc-dev/neo-go#4325, fetch nspcc-dev/dbft#164. Solves the problem described in #576 for non-blob transactions at the consensus level by adding the full list of serialized transactions to the PrepareRequest. For blob transactions the issue is still relevant. Missing blob sidecars will be requested in a separate callback and forwarded to dBFT once collected. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to bane-labs/go-ethereum
that referenced
this pull request
Oct 2, 2026
Implement nspcc-dev/neo-go#4325, fetch nspcc-dev/dbft#164. Solves the problem described in #576 for non-blob transactions at the consensus level by adding the full list of serialized transactions to the PrepareRequest. For blob transactions the issue is still relevant. Missing blob sidecars will be requested in a separate callback and forwarded to dBFT once collected. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part of nspcc-dev/neo-go#4325. An alternative to #160 aimed to still support the "missing transactions" part required for NeoX networks (ref. bane-labs/go-ethereum#655 (comment)).
TODO: