dbft: use designated type instead of []Transaction[H] - #166
Merged
Merged
Conversation
Member
Author
|
@roman-khimov should work, but need to check that on NeoGo. Depends on nspcc-dev/neo-go#4387. |
Allows to drop useless slice allocation code at the caller's side. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
shareable-txs
branch
from
October 1, 2026 16:47
2be91ec to
506e19b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 61.75% 62.11% +0.35%
==========================================
Files 32 32
Lines 1569 1560 -9
==========================================
Hits 969 969
+ Misses 599 590 -9
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Oct 1, 2026
AnnaShaleva
added a commit
to bane-labs/go-ethereum
that referenced
this pull request
Oct 2, 2026
Fetch nspcc-dev/dbft#166. Save some allocations, use types.Transaction directly instead of dbft.Transaction wrapper. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Member
Author
|
@roman-khimov tested with bane-labs/go-ethereum#665, works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to drop useless slice allocation code at the caller's side.