Improve file sync in ReplicateV2 - #4201
Merged
Merged
Conversation
cthulhu-rider
force-pushed
the
put-storage-stream-sync
branch
from
September 29, 2026 16:54
8be5613 to
1e774e5
Compare
8ae3abe made ReplicateV2 server to call `os.File.Write()` for FSTree's file multiple times. Since the file was previously opened with `O_DSYNC` flag, each write also made sync. More writes, more syncs. For example, Put performance tests showed degradation on mid- and large-size objects (4M and 64M in particular). This improves Linux server behavior by replacing open sync flag with deferred sync syscall. Same test runs showed results pretty close (a bit worse) to Replicate. At the same time, using ReplicateV2 uses less RAM. Refs #4157. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
put-storage-stream-sync
branch
from
September 29, 2026 16:56
1e774e5 to
2eae07c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4201 +/- ##
==========================================
- Coverage 31.61% 31.60% -0.01%
==========================================
Files 677 677
Lines 41570 41572 +2
==========================================
- Hits 13141 13140 -1
- Misses 28429 28432 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
marked this pull request as ready for review
September 29, 2026 19:07
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
September 29, 2026 19:07
roman-khimov
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.