Repository navigation
feat(server): show a file without reading it into context - #131
Merged
nullStack65 merged 4 commits intoNov 20, 2026
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Owner
Author
{"reviewed_head":"b63e16bc14225e5b926c4a67b2aa660593577e19","reviewer":"grok-4.7-build (claudeAgent, read-only)","findings":[{"id":"same-millisecond-show-file-never-opens","severity":"important","summary":"shownFilesToOpen opens a file only when its createdAt is strictly newer than the newest timestamp already painted. A tool row's createdAt is its startedAt and never changes on completion, so a show_file that starts in the same millisecond as anything already on screen completes with createdAt equal to the watermark and the viewer never opens.","outcome":"open"}]} |
Owner
Author
{"reviewed_head":"8d91345128c6a0b66b58e5a6955d4d8ae5f5f295","reviewer":"grok-4.7-build (claudeAgent, read-only)","findings":[]}The first re-check of 8632398 found completion-stamp-loses-to-later-start: the watermark was still the newest timeline start time, so a slow show_file lost to a row that started later. 8d91345 makes the watermark the newest completion. The same reviewer checked out that commit and returned clean. |
An agent had to read a file and paste it to put it on screen. show_file stats the path and returns only path, size, and type. The web client opens the existing file viewer from that result, so the file bytes stay out of the model context. Model: grok-4.7 Task: CLO-898 show a file without reading it into context Agent: magpie Lane: magpie Harness: t3/codex Model-family: Grok Model-generation: 4.7 Skills-SHA: 0540352af0d6f43bdeea39a8c4aad4660ab0ec55 Co-Authored-By: Grok 4.7 <noreply@x.ai>
History loading, an older page, and an expanded work group looked like new show_file results, so old files took the panel. A completion now opens only when it is newer than what is already on screen. show_file stays in the live window, Claude's read-only sandbox can call it, and the result is a showFile object so another tool's path and size cannot open the viewer. Model: grok-4.7 Task: CLO-898 show a file without reading it into context Agent: magpie Lane: magpie Harness: t3/codex Model-family: Grok Model-generation: 4.7 Skills-SHA: 0540352af0d6f43bdeea39a8c4aad4660ab0ec55 Co-Authored-By: Grok 4.7 <noreply@x.ai>
A tool row's createdAt is its startedAt and never moves when the tool finishes, so a show_file that starts in the same millisecond as something already painted completed with createdAt equal to the watermark and the viewer never opened. The open check now uses the completion time. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The watermark was the newest timeline start time, so a show_file that started before a later row never opened when it completed earlier than that row's start. The watermark is now the newest completion. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
nullStack65
force-pushed
the
t3/agent-file-display-no-read
branch
from
November 20, 2026 20:12
8d91345 to
cd35b71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An agent had to read a file and paste it to put it on screen.
show_filestats the path and returns only the path, byte size, and media type. The web client opens the existing file viewer from that result, so the file bytes stay out of the model context.Opening the viewer is the existing panel state update. The viewer reads the file after paint.
Deploy: fleet
Model: grok-4.7
Harness: t3/codex