Skip to content

fix(web): show linked environments as connected and clear their Failed pill - #150

Merged
nullStack65 merged 2 commits into
release/native-0.1.10from
fix/linked-sidebar-stale
Nov 21, 2026
Merged

nullStack65 merged 2 commits into
release/native-0.1.10from
fix/linked-sidebar-stale

Conversation

@nullStack65

Copy link
Copy Markdown
Owner

Problem

On a machine that only reaches another environment through a server link, the sidebar Environments filter showed a gray dot for that environment even while t3 environment list reported it reachable with live threads. Threads on that link also stayed on the Failed pill long after the host had completed them or the user had seen the failure.

A server link is reachable by the time the sidebar lists it, but it has no connection in the client catalog, and the filter only paints green for a catalog connection. The linked thread list also dropped the host's visit time, so every failed run looked unseen.

Change

The filter treats an environment the linked sidebar lists as connected, alongside catalog connections. The thread list item now carries lastVisitedAt, optional so an older peer that omits it still decodes, and the linked sidebar copies it into the rebuilt thread shell. A failure the user has not seen still shows Failed; a later visit or a completed run clears it.

Scope

Bug fix for the linked-environment sidebar added by the linked-environment threads issue (CLO-963, pull request 133). Tracked on the sidebar stale-state issue (CLO-1037).

Verification

  • packages/client-runtime src/state/linkedSidebar.test.ts: 4 passed. A failed linked thread stays unseen until the host records a later visit, and a completed linked thread drops the Failed pill.
  • apps/server src/peer/linkedSidebar.test.ts: 1 passed. The collector forwards the host's lastVisitedAt.
  • apps/web src/state/linkedSidebar.test.ts: 3 passed. A server-only link is reported for the filter dot.
  • effect-tsgo typecheck passed with no errors for packages/contracts, packages/client-runtime, and apps/server. apps/web has no typecheck script.
  • Not checked: a live sidebar on omarcy-desktop, because this change is not installed anywhere.

Deploy: none

Agent: grok/grok-4.7 through the Claude Code harness.

…d pill

A server-linked environment is reachable but has no catalog connection, so
the Environments filter painted it gray forever. A listed link is reachable
by construction, so the filter now treats it as connected.

Linked thread shells carried no visit time, so a failed run looked unseen
even after the host was visited or finished. The thread list now forwards
the host's lastVisitedAt and the shell uses it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

The linked shell dated a failed run by updatedAt, so a rename or settle
after the visit looked like a new failure. The list now carries the run's
own completion time. A visit that changes nothing else was also dropped,
because the sidebar compared threads without their visit time.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@nullStack65
nullStack65 merged commit 9972769 into release/native-0.1.10 Nov 21, 2026
3 checks passed
@nullStack65
nullStack65 deleted the fix/linked-sidebar-stale branch November 21, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant