Repository navigation
fix(server): stop the adapter and runtime tests hanging on stale approval and snooze behavior - #152
Conversation
…it tests stop waiting on snooze A full-access thread whose workspace disables Claude bypass opens its session in auto mode. The approval disposition treated the thread's policy as bypass and auto-allowed the command, so the permission callback returned before any request existed and the tests waiting on one hung until the 120s timeout. Full access now runs the command only while the session itself is in bypass. A downgraded session asks, and a removal check or deny rule still fails closed in every mode. The usage-limit tests still asked the recovery command to snooze a thread, which a limit no longer does. They snooze through the per-thread snooze instead, and the projection test checks the candidate query rather than the worker's arming. Model: grok/grok-4.7 Task: fix Agent: CoS delegate Harness: t3/claude-code Lane: magpie Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Model: grok/grok-4.7 Task: fix Agent: CoS delegate Harness: t3/claude-code Lane: magpie Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
…s lower The downgrade is the workspace disabling bypass, and the in-product notice says a full-access thread will not wait for approval. Gating the auto-allow on the session's own permission mode made a downgraded session ask again, which is the wait the earlier change removed. The allow follows the thread's policy again. A removal check or a deny rule still fails the command immediately. The tests that waited on an approval request for a downgraded full-access session now assert the allow decision instead. That request is never created, so the wait was the timeout. Model: grok/grok-4.7 Task: fix Agent: CoS delegate Harness: t3/claude-code Lane: magpie Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
START / checkpoint: Voice + founder inbox (Linux ARC) on head The failed job Reran the failed job only. Attempt 2 is queued as job Model: grok-4.7 |
Summary
What was actually failing
The reported six timeouts reproduced as three hangs and four fast assertion failures from two causes, not as leaked timers or a hung subprocess. Three hangs are in
ClaudeAdapterV2.test.ts("keeps late MCP display metadata" and the restricted-tools phases), where the test waits on an approval request the callback never emits. One fast failure is the full-access policy case in the same file. Two are inruntimeLayer.test.ts("guards a scheduled usage-limit continuation") and one related one is inProjectionStore.test.ts("does not freshly arm limit recovery for a subagent of a put-away parent"). No native-fork test timed out.Verification
vp test run src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts: 460 passed.runtimeLayer.test.ts:2297("wakes an idle coordinator for its task's question while another's lock is busy") asserts an event order and receives it reversed. It fails on the base commit as well, far from the edited lines, and is left as a known flake.vp run --filter t3 typecheck: exit 0, no errors. It still prints the pre-existingsuggestion TS377141diagnostics, which do not fail the build.Review
One independent review round, on grok-4.7 through the grok-direct provider. The preferred provider was out of usage until 2026-11-21 17:48 UTC, so the round ran on the same model through a different provider. The round found one defect: the first version gated the auto-allow on the session's own permission mode, so a downgraded full-access session asked again while the notice still said it would not. That is corrected in the follow-up commit, which restores the policy-based allow and asserts the allow decision in the tests that were waiting. The model the run actually executed was not reported by the provider.
Deploy: none
Model: grok/grok-4.7
Task: fix
🤖 Generated with Claude Code
Intent coverage
Owner: #146 · source ledger
docs/delivery/request-ledger/t3code-server-timeouts/pr-intent.json· ledger sha256e0cb6b8db0dcec6fa7b9d1724bc13e1f3ad0bb18c2962158e0300830feccf893Head/base: recomputed from Git by CI on every push; changing the ledger requires regenerating this section.
Sources: H1=agent_handoff/agent/public
Corrections: none recorded
Unrequested: apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts: Changed to carry out the proposed fix; pending acceptance of requirement R1.; apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts: Changed to carry out the proposed fix; pending acceptance of requirement R1.; apps/server/src/orchestration-v2/runtimeLayer.test.ts: Changed to carry out the proposed fix; pending acceptance of requirement R1.; apps/server/src/orchestration-v2/ProjectionStore.test.ts: Changed to carry out the proposed fix; pending acceptance of requirement R1.; docs/delivery/request-ledger/t3code-server-timeouts/pr-intent.json: Changed to carry out the proposed fix; pending acceptance of requirement R1.
Non-goals: Fixing the pre-existing wake-ordering flake at runtimeLayer.test.ts:2297, which fails independently of this change.; Merging the pull request or changing deployment.; Changing the usage-limit recovery behavior itself; only the tests that assumed the removed snooze arming were updated.
Mechanical completeness is checked; semantic adequacy and human authority require independent exact-head review. Source recorded, implemented, CI green, accepted, merged and installed are separate states.