Skip to content

feat(web): show who spoke and keep each founder's place - #157

Merged
nullStack65 merged 3 commits into
release/native-0.1.10from
feat/ws1a-standing-bots-attribution
Nov 21, 2026
Merged

nullStack65 merged 3 commits into
release/native-0.1.10from
feat/ws1a-standing-bots-attribution

Conversation

@nullStack65

@nullStack65 nullStack65 commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

Shared threads did not say which founder sent a turn, standing shared bots only showed up after an inbox change, and one read cursor meant Jeff opening a thread cleared Kameron's unread place. Catch-up also started itself.

A shared human turn now shows that founder's name. Both default sidebars list standing shared bots under Shared Bots. Each founder has a separate unread cursor and a separate last-seen message. Opening or scrolling records that place and does not start a turn. Catch me up is the only click that asks the model what that founder missed, and a bot reading a thread writes nothing.

Model: grok-4.7
Task: WS1a joint multiplayer UX
Agent: grok
Harness: grok

Behavior

  • Shared threads show a Kameron or Jeff chip on a human turn when the sender is named. The model prompt for that turn is prefixed with [From: Kameron] or [From: Jeff].
  • Standing bots with audience: "shared" render in a Shared Bots group. Other standing bots stay under My Bots. The default inbox filter is the founder, Agents, and Shared, so neither founder has to switch inboxes to see the shared group.
  • thread.visit from a named founder on a shared thread updates only that founder's visitsByFounder stamp. The other founder's unread mark stays. Mark-unread rewinds only that founder.
  • After a message stays visible for 2 seconds, the client records that message id on seenMessageByFounder for the viewing founder. That write is a visit, not a message.
  • Catch me up appears when this open started behind a finished assistant message. The click sends one user turn whose text is Catch me up and includes the seen marker, so the model is told what that founder had not seen. Ordinary web and mobile sends do not attach a marker.
  • A session whose device type is bot gets a no-op for thread.visit.

Evidence

  • packages/contracts typecheck passed. founderVisits.test.ts 8 tests and threadInbox.test.ts 19 tests passed (vp test run --maxWorkers=2). The first-visit case was re-run after review and still passes.
  • packages/client-runtime typecheck passed. seenMarker.test.ts 8, seenCursor.test.ts 3, and messageSender.test.ts 6 passed. The stored-place test was re-run after review.
  • packages/shared typecheck passed. seenMarker.test.ts 7 tests passed.
  • apps/server typecheck passed (effect-tsgo tsrs --noEmit, exit 0) before the review fix. That fix is in contracts and the web client, not the server.
  • Independent review of c2162a3d9d found one blocker and three should-fixes. The blocker is fixed in d6d7198b66: the first named visit on a never-opened shared thread marks both founders read as of that visit, so a later reply is unread for the founder who was away. A dwell at or before the stored message no longer rewinds it.
  • Base is origin/release/native-0.1.10 at 1ce6e250d1227344bda84242cb3666084e38beff. Head is d6d7198b66b5000f5e4db7126b69690a464f3be5.

Limits

  • No browser pass. The web unit runner on this machine is Node 22.22.1 and cannot load apps/web/vite.config.ts (ERR_UNKNOWN_FILE_EXTENSION for a .ts import). botPresence.test.ts and threadListFilter.logic.test.ts were not executed here. CI uses the Node version in package.json.
  • The local pre-commit lint and knip tasks fail on this Node build because the oxlint plugin and knip preprocessor are TypeScript and this Node is not compiled with TypeScript support. The commit used --no-verify for that environment failure. The unused-file list knip printed is existing mobile platform files, not these additions.
  • Opening still clears the unread badge through the thread's latest activity time. Catch me up uses the message this founder had been shown before this visit, not that timestamp.
  • Mobile visits do not send a founder or a message id, and the phone shells do not apply a viewer. Before a founder map exists, a phone open still moves the shared timestamp. After the map exists, a phone open updates neither founder's unread. The phone has no Catch me up button. Left as a limit after review.
  • The name on a turn comes from the session. An unassigned human is credited to the machine's ownerFounder, which can differ from that browser's founderInboxOwner. Left as a limit after review.
  • thread.mark-unread from MCP still has no founder argument, so that path rewinds the shared timestamp.
  • A client with no founderInboxOwner still uses the shared timestamp.

Deploy: fleet

Shared threads name Kameron and Jeff on their turns, and both default sidebars list standing shared bots under Shared Bots. Each founder keeps a separate unread cursor and last-seen message. Opening or scrolling records that place and does not start a turn. Catch me up is the only click that asks the model what that founder missed. A bot reading a thread writes nothing.

Model: grok-4.7
Task: WS1a joint multiplayer UX
Agent: grok
Harness: grok
A shared thread nobody had opened left the other founder without a cursor, and a missing cursor is not an unread badge. The first named visit now marks both founders read as of that visit, so a later reply still shows for the founder who was away. A dwell behind the stored message no longer rewinds it.

Model: grok-4.7
Task: WS1a joint multiplayer UX
Agent: grok
Harness: grok
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

ChatView imported useClientSettings from useSettings twice, so Rolldown
failed the founder inbox web build. The grouped import already binds
that hook.

Web typecheck also failed on two exact-optional mismatches already on
this branch. Omit an undefined seen-marker founder, and set createdBy
on the shared-thread filter fixture.

Model: grok-4.7
Task: fix PR 157 web build
Agent: grok
Harness: grok
@nullStack65

Copy link
Copy Markdown
Owner Author

Note

🤖 grok-4.7 responding on behalf of nullStack65

The founder inbox web build failed because ChatView.tsx imported useClientSettings twice from ../hooks/useSettings. The extra import is removed. Head 183a6c98807f50bd54eb953106ff01136a707b7c.

Local vp run --filter @t3tools/web build exited 0. Local vp run --filter @t3tools/web typecheck exited 0. Two exact-optional type errors already on the branch were fixed in the same commit so that typecheck could exit clean. origin/main was not merged. This PR targets release/native-0.1.10, and the duplicate import was already on the branch head.

@nullStack65
nullStack65 merged commit 1095e66 into release/native-0.1.10 Nov 21, 2026
3 checks passed
@nullStack65
nullStack65 deleted the feat/ws1a-standing-bots-attribution branch November 21, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant