Repository navigation
Conversation
Route seem to require Owner access to organization https://github.com/dani-garcia/vaultwarden/blob/1.37.4/src/api/core/organizations.rs#L264 As an admin of the organization, i get a 401 error when calling the route without this fix Only drawback: BillingEmail is set to empty string because we have nothing to set it from
Same fix but automatic instead of explicit Choose at your convenance between this and the previous commit
Author
|
Provided another solution in a second commit, which provides automatic handling instead of explicit caller choice. IMHO
Both look fine to me, but the automatic one is more user friendly, i guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for #39
Cause: the above route seem to require Owner access to organization https://github.com/dani-garcia/vaultwarden/blob/1.37.4/src/api/core/organizations.rs#L264
Effect : As an admin of the organization, i get a 401 error when calling the route without this fix ; With the provided fix, i get a usable downstream Organization from get_organization() built from information from a ProfileOrganization i provide from sync data.
Only drawback: BillingEmail is set to empty string because we have nothing to set it from.