Skip to content

fix(deps): upgrade Vite DevTools to 0.5.1, fix e2e client-context global - #1069

Merged
antfu merged 2 commits into
mainfrom
deps/vite-devtools-0.5.1
Aug 20, 2026
Merged

fix(deps): upgrade Vite DevTools to 0.5.1, fix e2e client-context global#1069
antfu merged 2 commits into
mainfrom
deps/vite-devtools-0.5.1

Conversation

@antfubot

Copy link
Copy Markdown
Collaborator

Summary

Upgrades @vitejs/devtools / @vitejs/devtools-kit from 0.5.00.5.1 (and devframe / @devframes/* ^0.9.2^0.9.4, which 0.5.1 requires), then fixes the e2e suite that has been hanging to the 15-minute CI cap ever since the v0.5 / Devframe v0.9 migration (#1065).

Why the e2e hangs (two layers)

  1. Renamed client-context global. The v0.5 migration renamed the host-page global window.__VITE_DEVTOOLS_CLIENT_CONTEXT__window.__DEVFRAME_HUB_CLIENT_CONTEXT__. The e2e ensureDockReady fixture (and three specs) still waited on the old name, so every DevTools-dependent test blocked 30s on a never-defined global and the suite blew the job timeout.
  2. Auth-disable no longer trusted the client. Even with the global renamed, VITE_DEVTOOLS_DISABLE_CLIENT_AUTH=true (used by the e2e web server) stopped marking the client RPC session trusted in 0.5.0, so the client stayed on the auth prompt and never mounted. Root-caused and reported upstream as Disabling client auth (clientAuth:false / VITE_DEVTOOLS_DISABLE_CLIENT_AUTH) no longer trusts the client in 0.5 vitejs/devtools#539; fixed in @vitejs/devtools@0.5.1 (PR fix(core): skip interactive-auth registration when client auth is disabled vitejs/devtools#540), which skips registering the interactive-auth handler when auth is disabled so devframe's auth:false auto-trust shim applies.

Changes

  • pnpm-workspace.yaml: vite-devtools ref ^0.5.0^0.5.1; devframe ref ^0.9.2^0.9.4.
  • tests/e2e/: rename __VITE_DEVTOOLS_CLIENT_CONTEXT____DEVFRAME_HUB_CLIENT_CONTEXT__ in the fixture and the devtools / data-inspector / code-server specs (13 refs, 4 files). The new global exposes the same shape (.rpc, .rpc.isTrusted, .docks.entries), so the change is mechanical.

Closes the e2e-hang tracking issue #1067.

Verification

  • pnpm install resolves @vitejs/devtools@0.5.1, @vitejs/devtools-kit@0.5.1, devframe@0.9.4, @devframes/hub@0.9.4; confirmed the installed 0.5.1 guards the interactive-auth registration with isClientAuthDisabled(context).
  • pnpm build (module + kit + ui-kit) succeeds.
  • ESLint clean on the changed files.
  • Final e2e green is validated by CI (local headless runs are unreliable in the sandbox this was prepared in).

This PR was created with the help of an agent.

Bumps `@vitejs/devtools`/`@vitejs/devtools-kit` to 0.5.1 (and devframe /
`@devframes/*` to ^0.9.4, which 0.5.1 requires).

0.5.1 fixes the upstream regression where disabling client auth
(`VITE_DEVTOOLS_DISABLE_CLIENT_AUTH` / `clientAuth: false`) no longer
trusted the client session (vitejs/devtools#539) — the cause of the e2e
suite hanging until the 15-minute CI cap.

The v0.5 migration also renamed the host-page client-context global
`__VITE_DEVTOOLS_CLIENT_CONTEXT__` -> `__DEVFRAME_HUB_CLIENT_CONTEXT__`;
update the e2e fixture and specs to the new name so `ensureDockReady`
stops waiting on a global that no longer exists.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nuxt-devtools with  Cloudflare Pages  Cloudflare Pages

Latest commit: 106f26d
Status: ✅  Deploy successful!
Preview URL: https://8d26e9e1.nuxt-devtools.pages.dev
Branch Preview URL: https://deps-vite-devtools-0-5-1.nuxt-devtools.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 28f9b6af-314b-4f54-89cd-793516b14756

📥 Commits

Reviewing files that changed from the base of the PR and between 106f26d and 4491bae.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

Updated the devframe and vite-devtools workspace anchors and catalog entries. Updated the E2E fixture to use __DEVFRAME_HUB_CLIENT_CONTEXT__ for RPC trust and dock readiness. Updated Code Server, Data Inspector, and registry tests to use the same context for dock lookups and RPC calls.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes both the dependency upgrade and the e2e client-context global fix.
Description check ✅ Passed The description directly explains the dependency upgrades, renamed global updates, e2e hang fix, and verification results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deps/vite-devtools-0.5.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@antfu
antfu merged commit 3d2ebf4 into main Aug 20, 2026
3 of 5 checks passed
@antfu
antfu deleted the deps/vite-devtools-0.5.1 branch August 20, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants