fix(deps): upgrade Vite DevTools to 0.5.1, fix e2e client-context global - #1069
Merged
Conversation
Bumps `@vitejs/devtools`/`@vitejs/devtools-kit` to 0.5.1 (and devframe / `@devframes/*` to ^0.9.4, which 0.5.1 requires). 0.5.1 fixes the upstream regression where disabling client auth (`VITE_DEVTOOLS_DISABLE_CLIENT_AUTH` / `clientAuth: false`) no longer trusted the client session (vitejs/devtools#539) — the cause of the e2e suite hanging until the 15-minute CI cap. The v0.5 migration also renamed the host-page client-context global `__VITE_DEVTOOLS_CLIENT_CONTEXT__` -> `__DEVFRAME_HUB_CLIENT_CONTEXT__`; update the e2e fixture and specs to the new name so `ensureDockReady` stops waiting on a global that no longer exists.
Deploying nuxt-devtools with
|
| Latest commit: |
106f26d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8d26e9e1.nuxt-devtools.pages.dev |
| Branch Preview URL: | https://deps-vite-devtools-0-5-1.nuxt-devtools.pages.dev |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
@vitejs/devtools/@vitejs/devtools-kitfrom0.5.0→0.5.1(anddevframe/@devframes/*^0.9.2→^0.9.4, which0.5.1requires), then fixes the e2e suite that has been hanging to the 15-minute CI cap ever since the v0.5 / Devframe v0.9 migration (#1065).Why the e2e hangs (two layers)
window.__VITE_DEVTOOLS_CLIENT_CONTEXT__→window.__DEVFRAME_HUB_CLIENT_CONTEXT__. The e2eensureDockReadyfixture (and three specs) still waited on the old name, so every DevTools-dependent test blocked 30s on a never-defined global and the suite blew the job timeout.VITE_DEVTOOLS_DISABLE_CLIENT_AUTH=true(used by the e2e web server) stopped marking the client RPC session trusted in0.5.0, so the client stayed on the auth prompt and never mounted. Root-caused and reported upstream as Disabling client auth (clientAuth:false / VITE_DEVTOOLS_DISABLE_CLIENT_AUTH) no longer trusts the client in 0.5 vitejs/devtools#539; fixed in@vitejs/devtools@0.5.1(PR fix(core): skip interactive-auth registration when client auth is disabled vitejs/devtools#540), which skips registering the interactive-auth handler when auth is disabled so devframe'sauth:falseauto-trust shim applies.Changes
pnpm-workspace.yaml:vite-devtoolsref^0.5.0→^0.5.1;devframeref^0.9.2→^0.9.4.tests/e2e/: rename__VITE_DEVTOOLS_CLIENT_CONTEXT__→__DEVFRAME_HUB_CLIENT_CONTEXT__in the fixture and thedevtools/data-inspector/code-serverspecs (13 refs, 4 files). The new global exposes the same shape (.rpc,.rpc.isTrusted,.docks.entries), so the change is mechanical.Closes the e2e-hang tracking issue #1067.
Verification
pnpm installresolves@vitejs/devtools@0.5.1,@vitejs/devtools-kit@0.5.1,devframe@0.9.4,@devframes/hub@0.9.4; confirmed the installed0.5.1guards the interactive-auth registration withisClientAuthDisabled(context).pnpm build(module + kit + ui-kit) succeeds.This PR was created with the help of an agent.