You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(prose): size inline code in headings without anchor links - #7291
📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality)
✨ New feature (a non-breaking change that adds functionality)
🧹 Chore (updates to the build process or auxiliary tools and libraries)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)
📚 Description
Noticed this while trying Docus on Content v4 in nuxt-content/docus#1470. Content v4 no longer installs @nuxtjs/mdc, so mdc.headings.anchorLinks isn't set and inline code in an h2 or h3 rendered at the body text-sm size. The heading size and weight were only applied through [&>a>code], so they were lost once the code sits directly in the heading, which is the default since #6735.
This PR moves the size and weight to [&_code] and keeps the dashed border, hover and transition on [&>a>code] since they only make sense on the link. h1 and h4 never sized code, so they are left as is.
No actionable comments were generated in the recent review.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: c5ed4a18-ff67-46f6-b71e-30ad9577272e
Commits
Reviewing files that changed from the base of the PR and between cb5271a and 40f7c22.
Files selected for processing: 2
src/theme/prose/h2.ts
src/theme/prose/h3.ts
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
Walkthrough
The H2 and H3 base classes now apply code font size and weight to all nested code elements, not only code inside links. The H2 link-specific border and hover styles remain unchanged.
The targeted heading-style fix is consistent with the stated behavior and is ready to merge.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly and concisely identifies the bug fix for inline code sizing in headings without anchor links.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The pull request description clearly describes the h2 and h3 inline code sizing bug and the selector changes that fix it.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.
Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Noticed this while trying Docus on Content v4 in nuxt-content/docus#1470. Content v4 no longer installs
@nuxtjs/mdc, somdc.headings.anchorLinksisn't set and inline code in anh2orh3rendered at the bodytext-smsize. The heading size and weight were only applied through[&>a>code], so they were lost once the code sits directly in the heading, which is the default since #6735.This PR moves the size and weight to
[&_code]and keeps the dashed border, hover and transition on[&>a>code]since they only make sense on the link.h1andh4never sized code, so they are left as is.📝 Checklist