fix(template): explain missing GTest for module tests - #253
Conversation
Background: Internal user reported behavior where missing GTest failed a default C++ native build This behavior is intentional with "<MODULE>_BUILD_TESTS:BOOL=ON" by default. Keep the tests on-by-default and better document the flag to disable. Assisted-by: Codex:GPT-5 Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (4)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe module template now documents its test option and C++ GTest requirements. CMake reports a targeted error when tests are enabled and GTest is unavailable. A parameterized test checks configuration with tests disabled, GTest available, and GTest unavailable. ChangesModule test configuration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change documents how to disable module tests and provides a targeted error when GTest is missing. It is ready for normal merge checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
wyli
left a comment
There was a problem hiding this comment.
Reviewed the GTest discovery change and generated documentation. The existing test defaults are preserved, and the missing-dependency error provides the correct module-scoped opt-out. All 17 targeted template/scaffolding tests passed locally, and the current CI checks are green.
Background
Internal user reported behavior where missing GTest failed a default C++ native build
Investigation and Update
This behavior is intentional with "_BUILD_TESTS:BOOL=ON" by default. Keep the tests on-by-default and better document the flag to disable.
Results
Local end-to-end test verified error reporting, default testing behavior.
Assisted-by: Codex:GPT-5
Summary by CodeRabbit
BUILD_TESTING=OFFdoes not disable module tests.