Skip to content

slides: safer undo, revision-aware saves and integrated review actions - #536

Open
nyblnet wants to merge 4 commits into
codex/kernel-document-statefrom
codex/slides-review
Open

nyblnet wants to merge 4 commits into
codex/kernel-document-statefrom
codex/slides-review

Conversation

@nyblnet

@nyblnet nyblnet commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Ordinary Undo now preserves newer collaborator values, and save completion leaves edits made during the write marked unsaved. Adopt the shared kernel history/save helpers while keeping grouping, selection repair and slide invariants in slides.

Recent changes lives beside Version history in Save and permits an explicit confirmed revert. Command search uses Command/Ctrl+K; text/notes editing lives in the notes panel; file-size inspection lives beside picture compression in About. Standard dropdowns use kernel menus. Visible thumbnails render on demand and unchanged canvas content retains its DOM. No new Tools menu, floating Save control or rule-based presentation-warning UI is introduced.

Validation: TypeScript and standalone build; shell gate; 3,000 structural history round trips and collaborator/budget tests; save adapter, assets, export secrets, i18n coverage, menu/dialog and sync-session rigs. Packaged Chrome checks cover desktop/phone-width controls, multi-slide drafts, undo/redo, save/reopen and delayed writes. All new rigs run in CI, with a pinned Playwright/Chromium job. The delayed writable is mocked; native mobile keyboards and OS permission dialogs are outside that test.

Depends on #535; merge kernel first, then retarget to main. #532 overlaps properties-panel construction and CSS: preserve its propsBody/Assistant setup and this PR's text/notes callback when integrating. The #516 font lifecycle follow-up is a separate PR.

Platform invariants: stable document identity, unchanged document format and splice contract, encryption-aware saves. Session changes are field-level and do not replace durable Version history.

@github-actions

github-actions Bot commented Sep 20, 2026

Copy link
Copy Markdown

Build size

codex/kernel-document-state (cf9749a) → codex/slides-review (2587a71)

app base PR change
bento/slides 658.5 KiB 670.2 KiB +11.6 KiB (+1.76%)
bento/spaces 264.7 KiB 264.7 KiB 0.0 KiB (0.00%)
bento/dash 406.5 KiB 406.5 KiB 0.0 KiB (0.00%)

Updated: 2026-09-20T20:56:42Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant