Skip to content

Validate Windows PE binary extension content beyond pe_type - #645

Open
christopher-stoppa wants to merge 1 commit into
oasis-open:masterfrom
christopher-stoppa:fix/windows-pebinary-ext-constraint
Open

christopher-stoppa wants to merge 1 commit into
oasis-open:masterfrom
christopher-stoppa:fix/windows-pebinary-ext-constraint

Conversation

@christopher-stoppa

Copy link
Copy Markdown

Summary

  • Enforce the STIX 2.1 requirement that a Windows PE Binary File Extension contain at least one defined property besides the required pe_type.
  • Preserve support for custom properties while ensuring they do not satisfy this extension-specific constraint.
  • Update valid fixtures and add direct and nested File regression tests.

Fixes #618.

Validation

  • python -m pytest stix2/test -q — 2519 passed, 3 xfailed, 1 xpassed.
  • pre-commit run --all-files — all hooks passed.
  • git diff --check — passed.

Reference

@CLAassistant

CLAassistant commented Sep 28, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

windows-pebinary-ext missing a co-constraint check

2 participants