Skip to content

Updated Android releases.yml for keystore and google-services secrets - #538

Open
hardikgarg02 wants to merge 7 commits into
ob-f:masterfrom
3dwesupport:android-release-secrets
Open

hardikgarg02 wants to merge 7 commits into
ob-f:masterfrom
3dwesupport:android-release-secrets

Conversation

@hardikgarg02

@hardikgarg02 hardikgarg02 commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator
  1. Updated Android releases.yml for keystore and google-services secrets
  2. Fixed the edge-to-edge screen layout issue on Android devices running Android 15 or above.
  3. Fixed issue for app crash in 16 KB devices.

@thias15

thias15 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Two gaps before this works: neither robot/build.gradle nor controller/build.gradle has a signingConfigs block wired to these injected properties, so assembleRelease would still produce an unsigned APK (likely named robot-release-unsigned.apk, not robot-release.apk as the asset-path step expects). Also, none of the 5 secrets this references (GOOGLE_SERVICES_JSON_BASE64, KEYSTORE_BASE64, KEYSTORE_PASSWORD, KEY_ALIAS, KEY_PASSWORD) exist in the repo yet. Can you add the signingConfigs block and confirm the secrets are ready before this merges?

@thias15

thias15 commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

google-services.json is decoded to both robot/google-services.json and robot/src/main/assets/google-services.json. Is the assets copy needed at runtime? If so, could you clarify where it’s consumed?

@harishthakur52

Copy link
Copy Markdown
Contributor

google-services.json is decoded to both robot/google-services.json and robot/src/main/assets/google-services.json. Is the assets copy needed at runtime? If so, could you clarify where it’s consumed?

Yes, the assets copy is needed at runtime. BarCodeScannerFragment.readJsonFile() (android/robot/src/main/java/org/openbot/app/robot/projects/BarCodeScannerFragment.java) opens google-services.json directly from context.getAssets() and parses it in getCurrentKeyFromJson() to extract the API key used for [barcode scanning / drive file access].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants