Skip to content

set shmSize for services - #1452

Merged
dnsi0 merged 24 commits into
feat/ltx-video-ugc-templatefrom
template-glm-5.2
Aug 25, 2026
Merged

set shmSize for services#1452
dnsi0 merged 24 commits into
feat/ltx-video-ugc-templatefrom
template-glm-5.2

Conversation

@dnsi0

@dnsi0 dnsi0 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Fixes # .

Changes proposed in this PR:

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a8611fe7-f25c-424d-ae1c-8ffa1120a74f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dnsi0
dnsi0 changed the base branch from feat/ltx-video-ugc-template to next-4 August 20, 2026 08:14
@dnsi0
dnsi0 changed the base branch from next-4 to feat/ltx-video-ugc-template August 20, 2026 09:24
@dnsi0
dnsi0 changed the base branch from feat/ltx-video-ugc-template to next-4 August 20, 2026 11:18
@dnsi0
dnsi0 marked this pull request as draft August 20, 2026 11:22
@dnsi0
dnsi0 changed the base branch from next-4 to feat/ltx-video-ugc-template August 25, 2026 11:20
@dnsi0
dnsi0 marked this pull request as ready for review August 25, 2026 11:42
@dnsi0 dnsi0 changed the title add glm 5.2 template set shmSize for services Aug 25, 2026
@dnsi0

dnsi0 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

/run-security-scan

@alexcos20 alexcos20 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI automated code review (Gemini 3).

Overall risk: low

Summary:
This PR successfully introduces support for necessary advanced Docker configurations (ShmSize, IpcMode, PidsLimit) to enable multi-GPU workloads. The architectural decision to read these parameters strictly from the operator's configuration (connResources) rather than user inputs is excellent and prevents dangerous sandbox escapes. The logic is applied consistently across both the initialization and restart workflows.

Comments:
• [INFO][style] There is a missing space after the hyphen, which will break the Markdown list rendering.

--**No privileged/advanced Docker config, with three narrow exceptions.** The service path
+- **No privileged/advanced Docker config, with three narrow exceptions.** The service path

• [INFO][security] Excellent job documenting the threat model and explicitly omitting dangerous properties (like Binds, CapAdd) from user control. Restricting IpcMode: 'host' to the operator's node configuration securely mitigates a severe container namespace escape vector while appropriately unblocking multi-GPU workloads.
• [INFO][bug] Good catch ensuring that the exact same constraints and advanced limits are resolved and applied in the restartService path. Omitting these during a restart is a common cause of silent state regressions. LGTM!

@dnsi0
dnsi0 merged commit 3f82a7f into feat/ltx-video-ugc-template Aug 25, 2026
6 of 7 checks passed
@dnsi0
dnsi0 deleted the template-glm-5.2 branch August 25, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants