Repository navigation
feat(node): keep refusal counts across restarts - #593
Open
LKSNDRTMLKV wants to merge 2 commits into
Open
LKSNDRTMLKV wants to merge 2 commits into
LKSNDRTMLKV wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #590
Summary
The node-health route reports two refusal counts,
signingFailuresTotalandrulesetLoadFailuresTotal. They were in-process counters, so a restart reset them: a node whose signing failed for a week could report0after one restart. They are now kept inodal.node_failure_counter(migration0048), so a restart does not clear them.Design
dpp_types::node_failure::NodeFailureCounteris the port.PgNodeFailureReporecords each refusal with one upsert, so two refusals racing each other cannot lose one./metricsstill reset on restart, as Prometheus counters do. The route no longer reads process memory, so the in-process counters from feat(node): add authenticated node health route #591 are removed.Stacking
This branch is stacked on
feat/138-authenticated-health-detail(#591). The #591 review fixes touch the same files (metrics.rs, the health route, the ruleset handler, the smoke test). Merge #591 into this branch and resolve in favour of this branch's design, which removes the in-process counters. Retarget tomainonce #591 merges.Verification
just check: exit 0, 1726 passed, 3 skipped.dpp-vaultintegration suite (integration-tests, shared Postgres): 599 passed, 12 skipped.dpp-nodesmoke suite: 36 of 36 passed.pg_node_failure(new, DAL): 1 of 1 passed, run before the last change, which touches only the vault handler.