Repository navigation
Number long browser chats correctly and name the page limits - #186
Merged
Merged
Conversation
The browser gets the latest 40 turns. turnCount lets it number them by their place in Desktop's transcript, so Edit and Regenerate branch from the turn the user picked in a long chat.
The browser fits a page to them before sending, instead of having a long address silently drop the turn.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
alichherawalla
added a commit
that referenced
this pull request
Oct 12, 2026
#186 counts every stored turn for the browser; the search test still asserted the list had none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #182 with fixes from the post-merge audit of Desktop, Desktop Pro and the browser extension. Goes with desktop-pro #98 and browser-extension #11 on
feat/browser-thin-client.turnCount, an optional field, so the browser can number turns as Desktop does. An older browser ignores it.MAX_PAGE_TITLE_CHARSandMAX_PAGE_URL_CHARSreplace the literals in the shared chat contract, so the browser can fit a page to them. The extension copy matches, apart from its header.reveal, card digits, and turn counts in the list.AGENTS.md: Desktop is built for macOS, Windows and Linux.Validation:
typecheck:nodepasses. 571 related tests pass under Electron's Node, and the pre-push gate passed.