Repository navigation
Native staging builds Pro's speaker-diarize helper on every platform - #216
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Build invocation and generated outputs scripts/stage-native.mjs, .gitignore |
The staging script runs the Pro build script when present. It uses build/linux-bin on Linux and resources/bin on other platforms. Spawn errors are thrown, and a nonzero exit status terminates the process. Git ignores the speaker diarization executables and model directory. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Merge Risk: 
a84e4
-
The change adds optional staging for the speaker diarization helper and ignores its generated outputs. No concrete merge-blocking defect was established. Before merging, confirm that the companion Pro script is named
build-speaker-diarize.mjs, matching what this script looks for. If Pro ships only a.shfile, the helper would be silently skipped.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly and concisely describes the main change: staging builds Pro's speaker-diarize helper on every platform. Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
alichherawalla
changed the title
Problem
Pro's meeting diarization (off-grid-ai/desktop-pro#123) moves to a native helper,
speaker-diarize, which runs pyannote Community-1 through speakrs on the CPU, on macOS, Linux and Windows. Native staging didn't build it, so a build would ship without it.Change
scripts/stage-native.mjsrunspro/scripts/build-speaker-diarize.mjson every platform, before the macOS-only helpers. It stages the helper and its models intoresources/bin(macOS, Windows) orbuild/linux-bin(Linux), which the existing extraResources rules ship..gitignoreignores the staged outputs.It skips when Pro doesn't have the script, so it can merge before or after the Pro PR. It needs cargo, which GitHub's macOS, Ubuntu and Windows runners have; CI fails without it, a local build warns and skips.
Not verified