Skip to content

Fix main CI: lint in the document turn test - #721

Merged
alichherawalla merged 1 commit into
mainfrom
fix/ci-build-shared-rag
Oct 15, 2026
Merged

alichherawalla merged 1 commit into
mainfrom
fix/ci-build-shared-rag

Conversation

@alichherawalla

@alichherawalla alichherawalla commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • OGAM main CI failed only on lint (prefer-template) in __tests__/integration/documents/turnDocuments.integration.test.ts.
  • The fixture's chapter text is now built with one template literal.
  • Same branch name as CI and release builds build the shared rag package OGAD#200 and off-grid-ai/desktop-pro#110.

Verification

  • npm run lint (eslint): 0 errors.

Summary by CodeRabbit

  • Tests
    • Consolidated each chapter’s text fragments in the atlas test fixture; generated text remains unchanged.

Main's lint failed on string concatenation in the test's fixture text.
@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: off-grid-ai/OGAM/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3bcac261-7ef8-4cb2-8426-fb9e0adc37c3
📥 Commits

Reviewing files that changed from the base of the PR and between b322535 and 577f0b8.

📒 Files selected for processing: 1
  • __tests__/integration/documents/turnDocuments.integration.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The atlas fixture combines each chapter’s text fragments in one template literal. The generated text content is unchanged.

Changes: Atlas fixture

Layer / File(s) Summary
Chapter text template
__tests__/integration/documents/turnDocuments.integration.test.ts
The orchard sentence and its five repetitions are part of the same template literal. The generated text content is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 577f0

This test-fixture change preserves the atlas text and introduces no material merge risk; it is ready for normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the lint failure, the code change, and the lint verification. It does not include the required Type of Change, Checklist, Related Issues, or Additional Notes sections. Add the missing template sections. Select the applicable change type, complete the relevant checklist items, state related issues or mark them as none, and add any relevant notes. Remove non-applicable sections such as screenshots if the te…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the lint fix in the document turn test. It is concise and related to the main change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Resolution

Add the missing template sections. Select the applicable change type, complete the relevant checklist items, state related issues or mark them as none, and add any relevant notes. Remove non-applicable sections such as screenshots if the template permits removal.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alichherawalla
alichherawalla merged commit 285501b into main Oct 15, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant