Skip to content

request is not a dependency, and it is deprecated #3

Description

@calvinf

Summary
The request module is not marked as a dependency, and it's used in the Fetch module.

Request
Make request a dependency or peerDependency in package.json.

Alternative
Because request is deprecated (as of February 11), an alternative would be to use something like cross-fetch (link) which will allow this module to work with both client-side (browser window.fetch natively or via polyfill) as well as server-side (via node-fetch).

I'm willing to contribute, let me know what approach you'd prefer.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions