Skip to content

refactor!: remove all deprecated members - #156

Open
szysas wants to merge 2 commits into
next-2from
next-3
Open

szysas wants to merge 2 commits into
next-2from
next-3

Conversation

@szysas

@szysas szysas commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Removes the deprecated surface accumulated in 6.x:

  • CoapRequest.withToken/withOptions/withPayload/withAddress - use modify()
  • CoapResponse.toSeparate(token, peer, transContext) and the same overload on CoapResponse.Builder
  • SeparateResponse 4-arg constructor
  • CoapOptionsBuilder.query(String) and the CoapRequest.Builder.query(String) that delegated to it, replaced by queries(List)/queries(String...)
  • BasicHeaderOptions.getUriQuery()/setUriQuery(String)

Adds modify() to CoapResponse and SeparateResponse for symmetry with CoapRequest, and converts the internal BlockWiseCallback, RegistrationManager and CLI SendCommand call sites.

@szysas
szysas added this pull request to stack #155 September 24, 2026 08:09
@szysas
szysas removed this pull request from stack #155 September 24, 2026 10:58
@szysas
szysas added this pull request to stack #159 September 24, 2026 10:59
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.53%. Comparing base (42d3b7a) to head (5c8b462).

Files with missing lines Patch % Lines
.../src/main/java/opencoap/core/SeparateResponse.java 76.47% 4 Missing ⚠️
...-core/src/main/java/opencoap/core/CoapRequest.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             next-2     #156      +/-   ##
============================================
- Coverage     93.64%   93.53%   -0.11%     
+ Complexity     1844     1834      -10     
============================================
  Files           108      108              
  Lines          4045     4054       +9     
  Branches        538      538              
============================================
+ Hits           3788     3792       +4     
- Misses          140      144       +4     
- Partials        117      118       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Removes the deprecated surface accumulated in 6.x:

- CoapRequest.withToken/withOptions/withPayload/withAddress - use modify()
- CoapResponse.toSeparate(token, peer, transContext) and the same
  overload on CoapResponse.Builder
- SeparateResponse 4-arg constructor
- CoapOptionsBuilder.query(String) and the CoapRequest.Builder.query(String)
  that delegated to it, replaced by queries(List)/queries(String...)
- BasicHeaderOptions.getUriQuery()/setUriQuery(String)

Adds modify() to CoapResponse and SeparateResponse for symmetry with
CoapRequest, and converts the internal BlockWiseCallback, RegistrationManager
and CLI SendCommand call sites.
@szysas
szysas marked this pull request as ready for review September 24, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant