Conversation
szysas
added this pull request to stack #155
September 24, 2026 08:10
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## next-3 #157 +/- ##
============================================
+ Coverage 93.53% 93.56% +0.02%
- Complexity 1834 1835 +1
============================================
Files 108 108
Lines 4054 4054
Branches 538 537 -1
============================================
+ Hits 3792 3793 +1
Misses 144 144
+ Partials 118 117 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
szysas
removed this pull request from stack #155
September 24, 2026 10:58
szysas
added this pull request to stack #159
September 24, 2026 10:59
Renames only, no behaviour change: - SignallingHeaderOptions -> SignalingHeaderOptions (RFC 8323 spelling, matching the SignalingOptions class in the same package); its members and methods follow the same spelling fix - coap-cli CoapSerializer -> CoapPacketCodec, so it no longer shadows opencoap.packet.CoapSerializer - CoapRequestEntityIncomplete -> CoapRequestEntityIncompleteException - CoapRequestEntityTooLarge -> CoapRequestEntityTooLargeException - CoapBlockTooLargeEntityException -> CoapBlockEntityTooLargeException - MessageIdSupplierImpl -> SequentialMessageIdSupplier - CapabilitiesStorageImpl -> HashMapCapabilitiesStorage - Method.iPATCH -> Method.IPATCH
The class holds numbers from the IANA CoAP Content-Formats registry, not MIME media types -- the MIME strings are only a side lookup table used by `contentFormatToString`. The new name matches the `Content-Format` option it describes and reads better at the call site. Constant names are left untouched here. BREAKING CHANGE: `MediaTypes` is now `ContentFormat`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames only, no behaviour change:
MediaTypes->ContentFormat(The class holds numbers from the IANA CoAP Content-Formats registry, notMIME media types)
SignallingHeaderOptions->SignalingHeaderOptions(RFC 8323 spelling, matching the SignalingOptions class in the same package); its members and methods follow the same spelling fixCoapSerializer->CoapPacketCodec, so it no longer shadows opencoap.packet.CoapSerializerCoapRequestEntityIncomplete->CoapRequestEntityIncompleteExceptionCoapRequestEntityTooLarge->CoapRequestEntityTooLargeExceptionCoapBlockTooLargeEntityException->CoapBlockEntityTooLargeExceptionMessageIdSupplierImpl->SequentialMessageIdSupplierCapabilitiesStorageImpl->HashMapCapabilitiesStorageMethod.iPATCH->Method.IPATCH