Repository navigation
Re-vendor 0.7.6 and the 0.7.7 preview from forge-cli v0.27.0 - #53
Merged
Merged
Conversation
… what they refuse forge-cli v0.27.0 (peeled c0e97c07) bundles 0.7.6 as the stable schema, which it has been since 0.26.0, and 0.7.7 as the preview. 0.7.2 to 0.7.5 are byte-identical to the copies here, so only 0.7.6 is replaced and 0.7.7 is added, both byte for byte; specs/ and schema-diffs/ are regenerated. New cases: - tests/0.7.6/trigger-continuous.json: trigger.type continuous (forge-cli #734, v0.22.0) beside cron, schedule, datasets, event and timetable, and one error for a non-object trigger. - tests/0.7.6/bitol-fields.json: the Bitol-shaped fields 0.7.6 gained after v0.21.0. - tests/0.7.7/: the 0.7.6 corpus at 0.7.7, plus stream-source, record-mapping and nested-columns groups. Mutation coverage: 0.7.6 45.7% (41.7% with no new cases), 0.7.7 48.2% (39.7%); the floor stays at 40. check_reference against 0.27.0: 1958 cases, 0 disagree. meta_test.py's stray-schema fixture used 0.7.7, which is now synced; it uses 0.7.8. The gate is unchanged.
- docs/releases/0.7.6.md is the stable release page, with trigger.type: continuous and the Bitol-shaped fields. - docs/releases/0.7.7.md is new: nested columns, properties.stream and properties.mapping. The map-key rule that fluid validate applies beyond the schema is noted as non-normative. - docs/schema/changelog.md and every status line say 0.7.6 stable and 0.7.7 preview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the pin from forge-cli v0.21.0 to v0.27.0 (peeled
c0e97c076f735205f4767f67f0bd05bcd78a47cd). 0.7.6 has been the stable schema there since 0.26.0, and 0.7.7 is the preview.What changes
fluid-schema-0.7.6.jsonis replaced andfluid-schema-0.7.7.jsonadded, both byte for byte from the tag.scripts/schema-versions.json:latestStable0.7.6,preview["0.7.7"],syncedthrough 0.7.7.specs/0.7.6,specs/0.7.7andschema-diffs/(including the newdiff-0.7.6-to-0.7.7) come from the locked renderer.tests/0.7.6/trigger-continuous.jsonpinstrigger.type: continuous(forge-cli #734): it is refused besidecron,schedule,datasets,eventandtimetable, and a non-object trigger gets exactly one error.tests/0.7.6/bitol-fields.jsonpins the Bitol-shaped fields 0.7.6 gained after v0.21.0. Descriptions lose the word "preview".tests/0.7.7/andtests/optional/0.7.7/start from the 0.7.6 corpus. Three groups are added:stream-source,record-mappingandnested-columns.tests/meta_test.py. The stray-schema fixture used 0.7.7, which is now synced, so it uses 0.7.8. The gate is unchanged.docs/releases/0.7.6.mdbecomes the stable page.docs/releases/0.7.7.mdis new.docs/schema/changelog.mdand every status line now say 0.7.6 stable and 0.7.7 preview.Gates (all exit 0)
tests/meta_test.pyconformance/run.pyconformance/mutation_coverage.py --min-coverage 40conformance/check_reference.pyagainst data-product-forge 0.27.0scripts/check-compat.pyscripts/check-schema-drift.pygenerate-docs.py --check,generate-schema-diffs.py --checknpm run docs:buildFor the maintainer
fluid validate0.27.0 refuses a map column whose key is not a required string ("supported map keys are required strings"), but the 0.7.7 schema accepts one. The valid map cases here declarerequired: true, so both agree, and0.7.7.mdnotes the rule as non-normative. Keep it that way, add an optional-tier case, or raise it upstream?specification.mdsection 1 tables, theanatomy.mdYAML blocks and examples 1–13. A rewrite against 0.7.6 would be a separate pass, like docs: state 0.7.5 stable and 0.7.6 preview, rewrite the specification against 0.7.5, and make every example validate #51.package.jsonsays 0.7.5 andpackage-lock.json0.7.4. Neither is touched here.