Repository navigation
chore: release the conformance assets as 0.1.0, not 1.0.0 - #448
Merged
Merged
Conversation
release-please opened #447 proposing 1.0.0. The manifest entry is "0.0.0", which it reads as "no release yet", and it then falls back to its default initial version of 1.0.0 — bump-minor-pre-major never gets a chance to apply, because there is no prior version to bump. 1.0.0 would be a claim this does not mean. Appendix F describes these assets as experimental and is not merged yet; the capability vocabulary, the control-API surface and the report schema are all still under review, and a 1.0.0 Go module says the opposite to anyone running `go get`. initial-version pins the first release to 0.1.0, leaving the patch digit for fixture corrections and the minor for new scenarios, both of which are expected. Once this merges release-please will re-propose #447 at 0.1.0. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli
added a commit
to open-feature/go-sdk-contrib
that referenced
this pull request
Oct 14, 2026
The assets branch was squash-merged as 2c5e8bb8 and deleted. The artifacts are byte-identical across the move -- the tree is f4a51f2b on both sides -- so no digest changes, only the revision this names. Still a pseudo-version: the module has no tag yet. open-feature/spec#448 sets the first release to 0.1.0, and this becomes a real version once that is cut. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
erka
approved these changes
Oct 14, 2026
toddbaert
approved these changes
Oct 16, 2026
aepfli
added a commit
to open-feature/go-sdk-contrib
that referenced
this pull request
Oct 16, 2026
The assets branch was squash-merged as 2c5e8bb8 and deleted. The artifacts are byte-identical across the move -- the tree is f4a51f2b on both sides -- so no digest changes, only the revision this names. Still a pseudo-version: the module has no tag yet. open-feature/spec#448 sets the first release to 0.1.0, and this becomes a real version once that is cut. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
erka
pushed a commit
to open-feature/go-sdk-contrib
that referenced
this pull request
Oct 19, 2026
The assets branch was squash-merged as 2c5e8bb8 and deleted. The artifacts are byte-identical across the move -- the tree is f4a51f2b on both sides -- so no digest changes, only the revision this names. Still a pseudo-version: the module has no tag yet. open-feature/spec#448 sets the first release to 0.1.0, and this becomes a real version once that is cut. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops #447 from cutting the conformance assets as 1.0.0.
Why it proposed 1.0.0
.release-please-manifest.jsoncarries"specification/assets/provider-tck": "0.0.0". release-please reads0.0.0as no release yet, so it never bumps from it — it falls back to its default initial version, which is1.0.0.bump-minor-pre-major: trueis already set and had no effect here, because there is no prior version to bump minor-instead-of-major.Why 1.0.0 is the wrong number
It is a compatibility claim, and
go getis where it gets read.@string-typingwas split out of@fully-typed-valuesduring review, which is exactly the kind of change 1.0.0 promises not to make.openapi/control-api.yaml) and the report schema (#425) are both open questions.What this changes
One line:
initial-version: "0.1.0"on the assets package.0.1.0rather than0.0.1because the first release is a feature, not a fix, and because it leaves both digits meaningful — patch for fixture corrections, minor for new scenarios. Both are expected: the testbed already owes two fixtures (flagd-testbed#392), and the open questions above will add scenarios.What to expect on merge
release-please re-runs on push to
mainand should update #447 to propose 0.1.0, taggingspecification/assets/provider-tck/v0.1.0once that is merged. Nothing is tagged by this PR.Four conformance implementations currently pin these assets by commit, because no tag exists yet. That tag is what lets Go name a version instead of a pseudo-version, so the number it carries is worth getting right before the first one is published — a tag is not practical to take back.