Skip to content

feat(notifications): add option to tag requesters when their request is available - #137

Open
kylepitcock wants to merge 3 commits into
openVESSL:devfrom
kylepitcock:feat/tag-requesters
Open

kylepitcock wants to merge 3 commits into
openVESSL:devfrom
kylepitcock:feat/tag-requesters

Conversation

@kylepitcock

@kylepitcock kylepitcock commented Oct 19, 2026 •

Copy link
Copy Markdown

Summary

  • Adds a dashboard option to tag requesters in the channel when their requested title becomes available.
  • Mentions go in the channel the request was made from, falling back to the notification channel.
  • Requesters made outside the bot are resolved from Seerr, and each title is only tagged once.

Notes

  • Off by default (NOTIFY_TAG_REQUESTERS).

@kylepitcock kylepitcock changed the title Implement option to tag requesters in dashboard feat(notifications): add option to tag requesters when their request is available Oct 19, 2026
@retardgerman
retardgerman changed the base branch from main to dev October 23, 2026 15:27
@retardgerman

Copy link
Copy Markdown
Contributor

Thanks for this, tagging requesters is a nice addition! A few things before it can go in:

Branch / conflict

  • I retargeted this to dev (all feature PRs go there first for beta testing).
  • The branch is based on the state before v1.6.3, so it conflicts in jellyfinWebhook.js. Could you rebase onto dev?

Scope

  • The two dashboard test tools (/api/test-tag-requesters and especially /api/test-workflow, ~220 lines in app.js) are a separate feature from the tagging itself. Could you move them into their own PR? That keeps this one focused and easier to review.

Seerr requester lookup

  • If fetchMediaRequesterIds fails, it returns [], but the title is still written to tagged-requests (5-year TTL). Those requesters then never get tagged. The title should only be marked when the lookup actually succeeded.
  • Because the lock is per title, anyone who requests the same show later (e.g. a new season via the Seerr web UI) is never tagged once the first episode of that show was announced.
  • The opposite case: after enabling the option, the next new episode of an older show tags everyone who requested it years ago.
  • Tracking the Seerr request IDs that were already tagged (instead of the title) and only looking at requests that aren't completed yet would solve both. Open to other ideas though.

i18n

  • The channel message (Your request **...** is now available!) is hardcoded. All user-facing strings need to go through locales/.
  • notify_tag_requesters_label and notify_tag_requesters_help were added to en.json but are missing from template.json.

Privacy

  • Tagging publicly shows who requested what, even if the request was made with ephemeral replies. It's opt-in, which is good, but please mention it in the help text so admins know before enabling it.

Also, how did you test this? Please test it against a real Discord + Jellyfin + Seerr setup before it lands on dev, since real users run that branch.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants