fix(deploy): refuse to install an ad-hoc bundle — it silently drops TCC grants - #13
Merged
Merged
Conversation
…CC grants TCC (Full Disk Access / Screen Recording / Accessibility) is keyed on the signing identity + bundle id, so an ad-hoc re-sign (codesign -s -) reads to macOS as a new app and drops every grant the human made — the Screens pane freezes and screenshot returns screen_recording=false. This happened repeatedly when a fast SSH deploy fell back to ad-hoc (openab-pty#37, #10 comment). deploy.sh now checks TeamIdentifier after signing and, before touching the LaunchAgent, refuses anything not signed by 6LPQNY95AQ (EXPECT_TEAM to change; ALLOW_ADHOC=1 for a throwaway local build). Net effect: the human grants each permission once and later deploys keep it. README says so. Verified: ad-hoc bundle → refused; the installed team-signed bundle → allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grants survive re-deploys now: deploy.sh refuses ad-hoc signatures, which were what dropped Screen Recording etc. after SSH deploys.