fix(tools): honor requested attach lease up to 24 hours - #41
Merged
Merged
Conversation
POST /admin/sessions/{session}/tools-attach now accepts optional {ttl_secs}. Omitted stays 1h; 1/2/4/12/24h requests are honored under the operator ceiling; zero or above the configured/hard 24h max is 400, never a successful silent clamp. tools_attach_ttl is now the ceiling (image default 24h), not a fixed lease.
Unit tests cover default/request/max and config bounds; HTTP e2e covers 1h default, 4h request, 0/86401 rejection. CLIENT-CONTRACT §9.1 and k8s how-to updated. macmini: clippy clean, 171 unit + 16 PTY e2e + 7 tools e2e pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the silent one-hour cap: the admin mint endpoint accepts optional
{ttl_secs}, defaults omitted requests to 1h, honors Connect/Remote 1/2/4/12/24h choices, and rejects zero/over-24h instead of clamping.tools_attach_ttlis the operator ceiling (default/hard max 24h). Tests/docs/image defaults included. Live integration with instance-mcp 0.6.4: requested 14400 → Mac/runtime both reported 14398s remaining.