Skip to content

fix(console): cap drilldown row height instead of only flooring it #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettchien merged 1 commit into from
Sep 13, 2026
Merged

fix(console): cap drilldown row height instead of only flooring it #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion console/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,12 @@ body {
align-items: stretch;
gap: 0;
margin: 0 0 16px;
min-height: var(--drilldown-row-h, auto);
/* Was `min-height` — a floor only, so a long chat transcript (or any other
tall column content) pushed the row past the window instead of clipping
to it (Brett: chat panel not fitting the window / not autoscrolling).
`height` makes the live-measured var a real ceiling too, matching how
`.is-split` below already caps the row while the editor is open. */
height: var(--drilldown-row-h, auto);
}
/* Nothing toggles `hidden` on this element today (deploy.ts used to; it now
hides `#config`/`#fleet-detail` in place instead, see deploy.ts), but the
Expand Down Expand Up @@ -252,6 +257,10 @@ body {
min-height: 0;
display: flex;
flex-direction: column;
/* The row's height is now a real ceiling (see `.drilldown-row` above) — give
this column its own scrollbar for content taller than that, same as the
chat log does, instead of silently clipping it. */
overflow-y: auto;
}
/* Same equal-specificity trap as `.debug-drawer[hidden]`/`.deploy-identity
[hidden]` above — `.drilldown-main > *` and the UA `[hidden]` rule tie, and
Expand Down
Loading