Skip to content

Reclaim abandoned trusted Git repositories - #61180

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/f45b60db82814b4bcc09365f68d808c73d2d5378
Nov 12, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/f45b60db82814b4bcc09365f68d808c73d2d5378

Conversation

@copyberry

@copyberry copyberry Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Reclaim abandoned trusted Git repositories

Why

Temporary trusted Git repositories can remain on disk when a process exits without running directory cleanup.

What changed

Use MarketplaceStagingDir for trusted Git repositories under Codex home's .tmp/.staging directory. Clean up abandoned staging directories before creating a repository, while ownership locks protect repositories still in use. Reject a symlinked .staging directory to keep GIT_DIR inside Codex home.

Testing

Update the cross-process staging test to create trusted Git repositories and verify that cleanup preserves live owners, reclaims a repository after its process exits, and leaves a concurrent checkout intact.

## Why

Temporary trusted Git repositories can remain on disk when a process exits without running directory cleanup.

## What changed

Use `MarketplaceStagingDir` for trusted Git repositories under Codex home's `.tmp/.staging` directory. Clean up abandoned staging directories before creating a repository, while ownership locks protect repositories still in use. Reject a symlinked `.staging` directory to keep `GIT_DIR` inside Codex home.

## Testing

Update the cross-process staging test to create trusted Git repositories and verify that cleanup preserves live owners, reclaims a repository after its process exits, and leaves a concurrent checkout intact.

GitOrigin-RevId: f45b60db82814b4bcc09365f68d808c73d2d5378
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/f45b60db82814b4bcc09365f68d808c73d2d5378 branch from 32976b0 to c37f817 Compare November 12, 2026 21:03
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor
Codex Review Summary: 🔄 Running

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-11-12T21:03:06.428812Z 32976b0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit c37f817 into main Nov 12, 2026
8 of 22 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/f45b60db82814b4bcc09365f68d808c73d2d5378 branch November 12, 2026 21:03
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant