Repository navigation
Support renaming cloud threads - #61182
Merged
copyberry[bot] merged 1 commit intoNov 12, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Handle `ThreadSetName` requests in the cloud backend through the cloud client's new `set_thread_name` method, without opening an attachment. Trim the requested name and reject empty names or thread IDs. After the server acknowledges the rename, update the matching loaded thread's name and emit `ThreadNameUpdated`. Leave the cached name unchanged and emit no notification if the request fails. ## Testing Add tests for the rename request payload, server acknowledgment and error handling, and preservation of the loaded thread's name when a rename fails. GitOrigin-RevId: eecfe17a9cfba50c9fa9091a38a36c0011ab9246
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/eecfe17a9cfba50c9fa9091a38a36c0011ab9246
branch
from
November 12, 2026 21:04
d6cde9d to
c432cf0
Compare
Contributor
Codex Review Summary: 🔄 RunningThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/eecfe17a9cfba50c9fa9091a38a36c0011ab9246
branch
November 12, 2026 21:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support renaming cloud threads
What changed
Handle
ThreadSetNamerequests in the cloud backend through the cloud client's newset_thread_namemethod, without opening an attachment. Trim the requested name and reject empty names or thread IDs.After the server acknowledges the rename, update the matching loaded thread's name and emit
ThreadNameUpdated. Leave the cached name unchanged and emit no notification if the request fails.Testing
Add tests for the rename request payload, server acknowledgment and error handling, and preservation of the loaded thread's name when a rename fails.