Repository navigation
test(react-native-to-swiftui): support CRLF in skill metadata regex - #44
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
Support optional carriage returns in the skill metadata regex so catalog tests pass deterministically across environments regardless of git checkout line-ending configuration, matching the pattern used in autodesk-fusion. Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
reginaldalfret
requested review from
harshpatel-oai,
sagar-vemuri-oai and
tonyloehr
as code owners
October 24, 2026 12:14
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When checking out the repository on systems or environments where files have CRLF line endings,
tests/react-native-to-swiftui/unit/catalog.test.mjsfails with:This PR updates the regex to
new RegExp("^---\\r?\\nname: " + skill + "\\r?\\n", "m"), matching the line-ending handling pattern already used intests/autodesk-fusion/unit/catalog.test.mjs.Validation
node --test tests/react-native-to-swiftui/unit/catalog.test.mjspasses (2/2)node scripts/validate-marketplace.mjsandnode scripts/validate-react-native-to-swiftui.mjspass