OBPIH-7963 Cycle Count - item with negative inventory - #102
Open
kkrawczyk123 wants to merge 6 commits into
Open
Conversation
alannadolny
reviewed
Aug 20, 2026
| await this.quantityCountedInput.pressSequentially(value, { | ||
| delay: 100, | ||
| }); | ||
| await this.page.waitForTimeout(300); |
Collaborator
There was a problem hiding this comment.
Why is it needed? Can't you wait for any item on the page instead of waiting for a hard-coded time?
Comment on lines
+18
to
+19
| rowByBinLocation(binLocationName: string) { | ||
| return new Row(this.page, this.rows.filter({ hasText: binLocationName }).first()); |
Collaborator
There was a problem hiding this comment.
I think we should have getRowsByBinLocation and then in the test call .first
Comment on lines
+24
to
+27
| async goToPerformCycleCount() { | ||
| await this.page.goto(`${CYCLE_COUNT_URL.base}?tab=TO_COUNT`); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
That URL with the tab should be placed in the URL files
| async searchProduct(productName: string) { | ||
| await this.searchInput.fill(productName); | ||
| await this.searchInput.click(); | ||
| await this.page.keyboard.press('ControlOrMeta+A'); |
Collaborator
There was a problem hiding this comment.
add a comment about the 'ControlOrMeta+A'
Comment on lines
+80
to
+96
| get negativeQuantityFilterGroup() { | ||
| return this.page.locator('.filter-group', { | ||
| has: this.page.locator('label[for="negativeQuantity"]'), | ||
| }); | ||
| } | ||
|
|
||
| get negativeQuantityCheckbox() { | ||
| return this.negativeQuantityFilterGroup.getByRole('checkbox'); | ||
| } | ||
|
|
||
| async openNegativeQuantityTooltip() { | ||
| const trigger = this.negativeQuantityFilterGroup.locator('[data-tooltipped]'); | ||
| await trigger.hover(); | ||
| const describedBy = await trigger.getAttribute('aria-describedby'); | ||
| return this.page.locator(`#${describedBy}`); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
can you explain what's going on with the negative here?
| confirmToRecountStepPage, | ||
| productShowPage, | ||
| }) => { | ||
| test.setTimeout(120_000); |
Collaborator
There was a problem hiding this comment.
Add a comment about what is taking so long to execute
| } | ||
| ); | ||
|
|
||
| test('Perform cycle count when item has negative inventory', async ({ |
Collaborator
There was a problem hiding this comment.
Can you somehow split that test into a few more?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added: