Repository navigation
fix: retain diagnostic logs for docs router failures - #273
Merged
Merged
Conversation
Member
Author
|
Independent exact-head review: 092d87f. No blocking source findings. Full source tree matches the previously inspected change; GitHub signature valid and parent unchanged. Best fix: configure observability at the deployment owner rather than add request logging or exception wrappers. Production TypeScript LOC: +0/-0; tests: +0/-0; configuration: +12 lines for retained diagnostics. Wrangler 4.131.1 schema and Cloudflare Workers Logs contract support separate invocation logging. Custom logs and uncaught exceptions remain collected; ordinary 5xx responses need analytics, and production retention requires post-deployment verification. Fresh exact-head CI must pass before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
HTTP failures on the documentation site could not be diagnosed from persisted Worker logs because production logging was disabled.
User Impact
After the router is deployed, operators can inspect future custom logs and uncaught exceptions. This cannot recover historical logs or establish the cause of earlier HTTP 500 responses.
Why This Change Was Made
Enable persistent logs at full sampling, disable routine invocation logs and tracing, and redact query strings from request URLs. This keeps failure evidence without creating a routine log for every successful asset request. Explicit HTTP 5xx responses still need HTTP-status analytics because they need not throw an exception.
No routing, storage, or response behavior changes. Logging increases stored diagnostic events. Merging triggers the repository's native router deployment workflow; production persistence must be verified afterward.
Evidence
git diff --checkpassed.092d87f0fa8da298d00089a65f1dacf0c9b2e138has the same full Git tree as the locally validated change; fresh exact-head review and CI are required before merge.Production persistence and exception collection still require verification after deployment.