remove cisco sflow deviation

[karthikeya-remilla]

Removing Cisco's sflow rate deviation as support is now added via feature.

Details are in https://partnerissuetracker.corp.google.com/issues/402672689

[OpenConfigBot]

Pull Request Functional Test Report for #6052 / 61378ca

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		SFLOW-1: sFlow Configuration and Sampling
Cisco 8000E		SFLOW-1: sFlow Configuration and Sampling
Cisco XRd		SFLOW-1: sFlow Configuration and Sampling
Juniper ncPTX		SFLOW-1: sFlow Configuration and Sampling
Nokia SR Linux		SFLOW-1: sFlow Configuration and Sampling
Openconfig Lemming		SFLOW-1: sFlow Configuration and Sampling

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista		SFLOW-1: sFlow Configuration and Sampling
Cisco		SFLOW-1: sFlow Configuration and Sampling
Juniper		SFLOW-1: sFlow Configuration and Sampling
Nokia		SFLOW-1: sFlow Configuration and Sampling

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up the codebase by removing a specific Cisco sFlow deviation that is no longer required due to the addition of native feature support. The changes involve updating the metadata definitions, removing associated helper functions, and simplifying the sFlow configuration logic in the plugin layer.

Highlights

• Removal of sflow_ingress_min_sampling_rate deviation: Removed the 'sflow_ingress_min_sampling_rate' deviation from the metadata proto and associated helper functions, as support for this feature is now natively implemented.
• Code cleanup: Updated 'internal/cfgplugins/sflow.go' to remove the conditional logic that previously relied on the deprecated deviation, simplifying the sFlow configuration process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the sflow_ingress_min_sampling_rate deviation from the metadata protobuf definitions, generated Go code, deviations package, and sflow configuration plugin. In internal/cfgplugins/sflow.go, the ingress sampling rate is now set directly using p.MinSamplingRate. Feedback was provided to add a nil check for the parameter p before accessing its fields to prevent a potential nil pointer dereference and runtime panic.