chore: Remove non-celery code owner monitoring code and docs - #551
rahulkanneri-2u wants to merge 1 commit into
Conversation
Removes the CodeOwnerMonitoringMiddleware, its supporting utilities, and the new_relic_search.py script/docs, since this web-request-based monitoring is 2U-specific and has already been replaced by plugin-based instrumentation. The celery task decorator (set_code_owner_attribute) and its shared helpers are intentionally left in place, since it is still in active use and its removal is tracked separately. Refs openedx#469
robrap
left a comment
There was a problem hiding this comment.
I misspoke. We should not be making any breaking changes, so the middleware also should not be removed. (Removal of the script could be considered a breaking change, but I am not counting that, so that is fine to stay.)
If we do anything, the most important change would be to add a deprecation warning to any public api that would be removed (e.g. middleware, celery function, etc.). We would also update the changelog.
Note: we need to timebox or not do any changes here. Thanks.
|
Closing without merging. Per review (#551 (review)).
|
Removes the non-celery code owner monitoring code, docs, and the new_relic_search script, since this functionality is 2U-specific and has already been replaced by plugin-based instrumentation. The celery task decorator (set_code_owner_attribute) and its shared helpers are intentionally left in place, since it is still in active use and its removal is tracked separately.
Description:
Removes
CodeOwnerMonitoringMiddlewareand its supporting non-celery utilities, tests, and docs, plus thenew_relic_search.pyscript and its docs. This is a trimmed-down replacement for #547, which mixed in premature removal ofutils.py(the still-in-use celery decorator,set_code_owner_attribute). This PR leavesutils.py,test_utils.py, and the celery-related ADRs untouched.JIRA:
#469
Dependencies:
None.
Merge deadline:
None currently.
Installation instructions:
None.
Testing instructions:
None.
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns:
List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.